- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.4k
 
🌱 Release Notes Generator - Test cases for main.go and ref.go #11882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Release Notes Generator - Test cases for main.go and ref.go #11882
Conversation
| 
           Welcome @irapandey!   | 
    
| 
           Hi @irapandey. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with  Once the patch is verified, the new status will be reflected by the  I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.  | 
    
| 
           @chandankumar4 - Can you take a look here please  | 
    
73540ca    to
    7c90cb5      
    Compare
  
    | 
           /ok-to-test  | 
    
| 
           /assign chandankumar4  | 
    
dd96f47    to
    5c63dc9      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks
| 
           LGTM label has been added. Git tree hash: e0e128671fa7e8b466ea91d29b477196b8f27802 
       | 
    
| 
           /approve  | 
    
| 
           You'll need an approve from a maintainer. It's in my queue, just not highest priority considering we are 2 weeks away from code freeze :)  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some improvements :-)
60b0d51    to
    1a752b4      
    Compare
  
    1a752b4    to
    3212ba5      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| 
           LGTM label has been added. Git tree hash: b9494911dbb568c7581d9c79c352a3fca0f2f482 
       | 
    
| 
           /retest  | 
    
| 
           /assign  | 
    
| 
           Thx! /approve  | 
    
| 
           [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chandankumar4, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
      
 Approvers can indicate their approval by writing   | 
    
What this PR does / why we need it:
This PR adds unit tests for release note generator to add more coverage to non-covered functions
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
This PR partially fixes #11368
Will raise small PRs to make review easier
/area testing