Skip to content

🚀 Release v1.10.0-rc.0 #12071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

🚀 Release v1.10.0-rc.0 #12071

merged 1 commit into from
Apr 8, 2025

Conversation

@chandankumar4
Copy link
Contributor

@chandankumar4 chandankumar4 commented Apr 8, 2025 •
edited
Loading

What this PR does / why we need it:

  • Release notes for v1.10.0-rc.0

Which issue(s) this PR fixes
Part of: #11656

/area release

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 8, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 8, 2025
@chandankumar4 chandankumar4 marked this pull request as ready for review April 8, 2025 14:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2025
@mboersma
Copy link
Contributor

mboersma commented Apr 8, 2025 •
edited
Loading

@chandankumar4 it looks like we pulled in changes that are only in the main branch, like:

- API: Add v1beta2 types (#12037)

When I did a dry run yesterday, I didn't see this, and the links all pointed to the cherry-picked release-1.10 PRs. 😕

RELEASE_TAG=v1.10.0-rc.0 PREVIOUS_RELEASE_TAG=tags/v1.10.0-beta.1 make release-notes

@chandankumar4 chandankumar4 force-pushed the release-v1.10.0-rc.0 branch from 638fb0e to 0140d5e Compare April 8, 2025 15:27
mboersma
mboersma approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f117b61dd71d06294fe245cc8c5ebdf15e816b5f

sbueringer
sbueringer reviewed Apr 8, 2025
View reviewed changes
CHANGELOG/v1.10.0-rc.0.md
@@ -0,0 +1,417 @@
🚨 This is a RELEASE CANDIDATE. Use it only for testing purposes. If you find any bugs, file an [issue](https://github.com/kubernetes-sigs/cluster-api/issues/new).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to have the highlights + Deprecation and Removals Warning like in previous release notes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@sbueringer
Copy link
Member

/approve
/hold

Feel free to merge once the finding is addressed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025
@chandankumar4
🚀 Release v1.10.0-rc.0
c1548c2 
Signed-off-by: chandankumar4 <[email protected]>
@chandankumar4 chandankumar4 force-pushed the release-v1.10.0-rc.0 branch from 0140d5e to c1548c2 Compare April 8, 2025 16:13
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mboersma April 8, 2025 16:13
mboersma
mboersma approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aaad9047c24d34d3236f013f92b6dbe206552ec1

@k8s-ci-robot k8s-ci-robot merged commit df72551 into kubernetes-sigs:main Apr 8, 2025
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Apr 8, 2025
@chandankumar4 chandankumar4 deleted the release-v1.10.0-rc.0 branch April 8, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@cahillsf cahillsf Awaiting requested review from cahillsf

@serngawy serngawy Awaiting requested review from serngawy

@cprivitere cprivitere Awaiting requested review from cprivitere

@sreeram-venkitesh sreeram-venkitesh Awaiting requested review from sreeram-venkitesh

+1 more reviewer

@mboersma mboersma mboersma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mboersma mboersma

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.11

Development

Successfully merging this pull request may close these issues.

4 participants

@chandankumar4 @k8s-ci-robot @mboersma @sbueringer