🌱 Bump golangci-lint v2 #12088
Merged
🌱 Bump golangci-lint v2 #12088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
needs-rebase
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
2 times, most recently
from
d79565d to
de82fdf
Compare
k8s-ci-robot
removed
the
needs-rebase
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
6 times, most recently
from
2b74f5d to
988c2a5
Compare
k8s-ci-robot
added
size/XXL
sivchari
commented
Apr 13, 2025
|
/assign @chrischdi |
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
from
988c2a5 to
d183f07
Compare
chrischdi
reviewed
Apr 14, 2025
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
2 times, most recently
from
7e874af to
15b826a
Compare
sbueringer
reviewed
May 7, 2025
There was a problem hiding this comment.
@sivchari Thank you, great work!
Sorry for the delay, I'm just back from PTO. If you have time, would appreciate a quick follow-up to unblock some other PRs in our pipeline
Signed-off-by: sivchari <[email protected]>
k8s-ci-robot
removed
the
lgtm
|
@sbueringer |
|
No worries. I suspected something like that, given the re-orderings in the config files |
|
@sivchari Almost there, please check the conversations above. I unresolved some |
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
from
648664c to
f5bfe34
Compare
sbueringer
reviewed
May 8, 2025
Signed-off-by: sivchari <[email protected]>
sivchari
force-pushed
the
migrate-golangci-lint-v2
branch
from
faf44d5 to
bad2b67
Compare
|
Okay, if CI is green now I'm going to merge this PR after #12148 is merged |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 702ec0ed2e8ae771d366835c6790299e0cb3ec6a
|
|
/approve |
k8s-ci-robot
added
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tylerauerbeck
pushed a commit
to tylerauerbeck/cluster-api
that referenced
this pull request
May 12, 2025
* migrate .golangci.yml for v2 Signed-off-by: sivchari <[email protected]> * fix lint error Signed-off-by: sivchari <[email protected]> * migrate golangci-lint-kal for v2 Signed-off-by: sivchari <[email protected]> * restore GOLANGCI_LINT_VER Signed-off-by: sivchari <[email protected]> * re-fix: upstream lint error Signed-off-by: sivchari <[email protected]> * preserve comments Signed-off-by: sivchari <[email protected]> * fix review points Signed-off-by: sivchari <[email protected]> * move exclude-use-default correctly Signed-off-by: sivchari <[email protected]> * use presets instead Signed-off-by: sivchari <[email protected]> * restore comment Signed-off-by: sivchari <[email protected]> * remove presets Signed-off-by: sivchari <[email protected]> --------- Signed-off-by: sivchari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
golangci-lint v2 is already released and it's so helpful to maintain codebase until now and from now on, so let's migrate it from v1 to v2.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #12087
/kind cleanup
/kind bug
/area ci