Skip to content

✨ Bump KAL to pick up latest requiredfields linter, add Min/MaxLength to BootstrapToken #12563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Aug 1, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10852

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from elmiko August 1, 2025 07:59
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Aug 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from g-gaston August 1, 2025 07:59
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 1, 2025
@sbueringer sbueringer changed the title [WIP] Bump KAL to pick up latest requiredfields linter [WIP] ✨ Bump KAL to pick up latest requiredfields linter Aug 1, 2025
@sbueringer sbueringer added the area/api Issues or PRs related to the APIs label Aug 1, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Aug 1, 2025
@sbueringer sbueringer added area/ci Issues or PRs related to ci and removed area/api Issues or PRs related to the APIs labels Aug 1, 2025
@sbueringer sbueringer force-pushed the pr-bump-kal-one-more-time branch 3 times, most recently from a91db53 to 1356666 Compare August 1, 2025 13:51
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 1, 2025
@sbueringer sbueringer force-pushed the pr-bump-kal-one-more-time branch from 1356666 to 8beba7d Compare August 9, 2025 07:36
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2025
@sbueringer sbueringer changed the title [WIP] ✨ Bump KAL to pick up latest requiredfields linter ✨ Bump KAL to pick up latest requiredfields linter, add Min/MaxLength to BootstrapToken Aug 9, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Aug 9, 2025

Let's backport this into release-1.11. I think this shouldn't break anyone. (also I think this field is very very rarely used)

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

Let's backport this into release-1.11. I think this shouldn't break anyone

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member Author

/assign @sivchari @JoelSpeed

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fc1b2cd01c9c3f0573e1c9b1533d21a7cdc52888

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit a5e21a3 into kubernetes-sigs:main Aug 11, 2025
29 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Aug 11, 2025
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #12604

In response to this:

Let's backport this into release-1.11. I think this shouldn't break anyone. (also I think this field is very very rarely used)

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants