Skip to content

🐛 Fix objects with Changed Resource Versions flake #12848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

🐛 Fix objects with Changed Resource Versions flake #12848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/framework/resourceversion_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ func ValidateResourceVersionStable(ctx context.Context, proxy ClusterProxy, name
}()
// This is intentionally failing on the first run.
g.Expect(objectsWithResourceVersion).To(BeComparableTo(previousResourceVersions))
}, 1*time.Minute, 15*time.Second).Should(Succeed(), "resourceVersions never became stable")
}, 2*time.Minute, 15*time.Second).MustPassRepeatedly(4).Should(Succeed(), "resourceVersions never became stable")

// Verify resourceVersions are stable for a while.
byf("Check resourceVersions remain stable")
Consistently(func(g Gomega) {
objectsWithResourceVersion, objects, err := getObjectsWithResourceVersion(ctx, proxy, namespace, ownerGraphFilterFunction)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(previousResourceVersions).To(BeComparableTo(objectsWithResourceVersion), printObjectDiff(previousObjects, objects))
}, 2*time.Minute, 15*time.Second).Should(Succeed(), "resourceVersions didn't stay stable")
}, 2*time.Minute, 5*time.Second).Should(Succeed(), "resourceVersions didn't stay stable")
}

func printObjectDiff(previousObjects, newObjects map[string]client.Object) func() string {
Expand Down