🌱 removing v1beta1 from admissionReviewVersions & conversionReviewVersions

[irapandey]

What this PR does / why we need it:
This PR removes v1beta1 from admissionReviewVersions & conversionReviewVersions as v1 is now stable.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #13096

/area misc

[k8s-ci-robot]

Hi @irapandey. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fabriziopandini]

/ok-to-test

[fabriziopandini]

/test

[k8s-ci-robot]

@fabriziopandini: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main

/test pull-cluster-api-e2e-blocking-main

/test pull-cluster-api-e2e-conformance-ci-latest-main

/test pull-cluster-api-e2e-conformance-main

/test pull-cluster-api-e2e-latestk8s-main

/test pull-cluster-api-e2e-main

/test pull-cluster-api-e2e-main-gke

/test pull-cluster-api-e2e-mink8s-main

/test pull-cluster-api-e2e-upgrade-1-35-1-36-main

/test pull-cluster-api-test-main

/test pull-cluster-api-test-mink8s-main

/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main

pull-cluster-api-build-main

pull-cluster-api-e2e-blocking-main

pull-cluster-api-test-main

pull-cluster-api-verify-main

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fabriziopandini]

/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-test-mink8s-main

[sbueringer]

Do we know in which Kubernetes versions v1 was introduced in both cases?

(xref: #13096 (comment))

[irapandey]

For AdmissionReview - it was v1.16 - https://github.com/kubernetes/kubernetes/blob/bf0e7b694f3a7355c200241825b6688ad391fae8/CHANGELOG/CHANGELOG-1.16.md?plain=1#L1781

For ConversionReview - it was 1.17 - https://github.com/kubernetes/kubernetes/blob/bf0e7b694f3a7355c200241825b6688ad391fae8/CHANGELOG/CHANGELOG-1.17.md?plain=1#L3165

I see the min versions in version.go

const (
	// MinimumKubernetesVersion defines the minimum Kubernetes version that can be used in a Management Cluster.
	MinimumKubernetesVersion = "v1.20.0"

	// MinimumKubernetesVersionClusterTopology defines the minimum Kubernetes version that can be used in a
	// Management Cluster when enabling the ClusterTopology feature gate.
	MinimumKubernetesVersionClusterTopology = "v1.22.0"
)

[irapandey]

Hey @sbueringer
Can you check if the comment above helps?

Thanks 😄

[sbueringer]

Thank you very much, yup!

I just found one additional occurrence

[sbueringer]

Please also drop v1beta1 from:

cluster-api/internal/topology/upgrade/clusterctl_upgrade_test.go

Line 1371 in ecbf101

ConversionReviewVersions: []string{"v1", "v1beta1"},

[irapandey]

sure

[irapandey]

Hey @sbueringer - PTAL, removed the occurrence you mentioned and squashed the PR commits to one.

Thanks 😄

[sbueringer]

Perfect, thank you very much!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 451a67ebc15ab2852fac8499c54f400b83ab584b

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment