Skip to content

⚠️ Bump Runtime Hooks v1alpha1 types to core CAPI v1beta2 #13200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jan 15, 2026
Merged

⚠️ Bump Runtime Hooks v1alpha1 types to core CAPI v1beta2 #13200

k8s-ci-robot merged 1 commit into from
Jan 15, 2026

Conversation

@sbueringer
Copy link
Member

@sbueringer sbueringer commented Dec 29, 2025 •
edited
Loading

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
This PR bumps the embedded core CAPI API types in the v1alpha1 Runtime Hooks API to v1beta2.
Otherwise these APIs would entirely break once we remove the v1beta1 core CAPI API types.

This should be okay given the API guarantees of v1alpha1 APIs (the impact on users should be also minimal)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #11920

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 29, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Dec 29, 2025
@sbueringer sbueringer mentioned this pull request Dec 29, 2025
Open
10 tasks
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 29, 2025
@sbueringer sbueringer added area/api Issues or PRs related to the APIs area/runtime-sdk Issues or PRs related to Runtime SDK labels Dec 29, 2025
@k8s-ci-robot k8s-ci-robot removed do-not-merge/needs-area PR is missing an area label labels Dec 29, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Dec 29, 2025

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-35-1-36-main

@sbueringer sbueringer changed the title [WIP] ⚠️ Bump Runtime Hooks v1alpha1 types to core CAPI v1beta2 ⚠️ Bump Runtime Hooks v1alpha1 types to core CAPI v1beta2 Dec 30, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2025
@sbueringer
Copy link
Member Author

sbueringer commented Dec 30, 2025

/hold
For discussion in the next CAPI office hours

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2025
@sbueringer
Bump Runtime Hooks v1alpha1 types to core CAPI v1beta2
4b48808 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-prepare-hooks-v1beta1-removal branch from 448bde4 to 4b48808 Compare December 30, 2025 14:20
@sbueringer
Copy link
Member Author

sbueringer commented Dec 30, 2025

Rebased onto latest main

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-35-1-36-main

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 30, 2025

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 4b48808 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member

fabriziopandini commented Jan 15, 2026

Great to see this change happening, and in a way that minimize impacts on users.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 15, 2026

LGTM label has been added.

DetailsGit tree hash: 406425639c75a12a7efd32d65211b5a3c76ec123

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2026
@sbueringer
Copy link
Member Author

sbueringer commented Jan 15, 2026

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2026
@k8s-ci-robot k8s-ci-robot merged commit b1f040f into kubernetes-sigs:main Jan 15, 2026
24 of 25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Jan 15, 2026
@sbueringer sbueringer deleted the pr-prepare-hooks-v1beta1-removal branch January 15, 2026 17:42
@sbueringer sbueringer mentioned this pull request Jan 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

Assignees

@fabriziopandini fabriziopandini

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.13

Development

Successfully merging this pull request may close these issues.

3 participants

@sbueringer @k8s-ci-robot @fabriziopandini