✨ Only set ownerReference on InfraCluster/ControlPlane when Topology is defined#13332
✨ Only set ownerReference on InfraCluster/ControlPlane when Topology is defined#13332sivchari wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
… defined Signed-off-by: sivchari <shibuuuu5@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
size/L
| // the user or external tools (e.g., metacontroller), so CAPI should not | ||
| // set ownerReference to avoid interfering with their lifecycle management. | ||
| if cluster.Spec.Topology.IsDefined() { | ||
| if err := controllerutil.SetControllerReference(cluster, obj, c.Scheme()); err != nil { |
There was a problem hiding this comment.
We should always set an ownerRef. It's just that with topology it's a controller ownerRef (an ownerRef with controller true)
…s not defined Address review feedback: ownerReference should always be set for cascade deletion. When Topology is defined, use SetControllerReference (controller: true) so CAPI fully manages the lifecycle. When Topology is not defined, use SetOwnerReference (controller: false) to enable cascade deletion while allowing external tools to set their own controller ownerReference.
3 participants
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #13256