🐛 Fix bug while setting status for deprecated fields

[Karthik-K-N]

What this PR does / why we need it:

While setting the deprecated conditions for object where the deprecated condition field is not in standard path (status.deprecated.v1beta1) but instead at different path(status.deprecated.v1beta2) for whatsoever reason we end up hitting below error

E0212 16:37:14.665519      15 controller.go:474] "Reconciler error" err="failed to init patch helper: failed to identify condition fields for object default/ibm-powervs-1-control-plane-lt47g: obj.status.deprecated.v1beta1 must be a pointer" controller="ibmpowervsmachine" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="IBMPowerVSMachine" IBMPowerVSMachine="default/ibm-powervs-1-control-plane-lt47g" namespace="default" name="ibm-powervs-1-control-plane-lt47g" reconcileID="e0b8bb3c-68c5-4fda-912d-0d053aee6ebc"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[Karthik-K-N]

/cc @sbueringer

[sivchari]

Thx!
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: dabd5e8a80a14f6d1efaf914cdfc88334ffc828d

[sbueringer]

Makes sense, thank you!

Please note that while this fix makes sense, it won't lead to patchHelper detecting v1beta2 paths correctly.

I think you have to additionally pass in the Metav1ConditionsFieldPath & Clusterv1ConditionsFieldPath options (which might be already your plan anyway :))

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/cherry-pick release-1.12

[sbueringer]

/cherry-pick release-1.11

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #13344

Details

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #13345

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.