Skip to content

🐛 Fix RenewDeadline typo in leader election #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2024
Merged

🐛 Fix RenewDeadline typo in leader election #3032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/leaderelection/leader_election.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ type Options struct {
// will use for holding the leader lock.
LeaderElectionID string

// RewnewDeadline is the renew deadline for this leader election client
RewnewDeadline time.Duration
// RenewDeadline is the renew deadline for this leader election client
RenewDeadline time.Duration
}

// NewResourceLock creates a new resource lock for use in a leader election loop.
Expand Down Expand Up @@ -99,7 +99,7 @@ func NewResourceLock(config *rest.Config, recorderProvider recorder.Provider, op
EventRecorder: recorderProvider.GetEventRecorderFor(id),
},
config,
options.RewnewDeadline,
options.RenewDeadline,
)
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/manager/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ func New(config *rest.Config, options Options) (Manager, error) {
LeaderElectionResourceLock: options.LeaderElectionResourceLock,
LeaderElectionID: options.LeaderElectionID,
LeaderElectionNamespace: options.LeaderElectionNamespace,
RewnewDeadline: *options.RenewDeadline,
RenewDeadline: *options.RenewDeadline,
})
if err != nil {
return nil, err
Expand Down
4 changes: 2 additions & 2 deletions pkg/manager/manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ var _ = Describe("manger.Manager", func() {
LeaderElectionNamespace: "default",
LeaderElectionID: "test-leader-election-id",
newResourceLock: func(config *rest.Config, recorderProvider recorder.Provider, options leaderelection.Options) (resourcelock.Interface, error) {
if options.RewnewDeadline != 10*time.Second {
return nil, fmt.Errorf("expected RenewDeadline to be 10s, got %v", options.RewnewDeadline)
if options.RenewDeadline != 10*time.Second {
return nil, fmt.Errorf("expected RenewDeadline to be 10s, got %v", options.RenewDeadline)
}
var err error
rl, err = leaderelection.NewResourceLock(config, recorderProvider, options)
Expand Down