Skip to content

✨ Expose all Go runtime metrics #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2025
Merged

✨ Expose all Go runtime metrics #3070

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bec486
add GoCollector and rocessCollector
dongjiang1989 Jan 14, 2025
85fc176
move to internal/controller/metrics
dongjiang1989 Jan 15, 2025
bf0ef29
default add all go runtime metrics
dongjiang1989 Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions pkg/metrics/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ limitations under the License.

package metrics

import "github.com/prometheus/client_golang/prometheus"
import (
"regexp"

"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/collectors"
)

// RegistererGatherer combines both parts of the API of a Prometheus
// registry, both the Registerer and the Gatherer interfaces.
Expand All @@ -27,4 +32,22 @@ type RegistererGatherer interface {

// Registry is a prometheus registry for storing metrics within the
// controller-runtime.
var Registry RegistererGatherer = prometheus.NewRegistry()
var Registry RegistererGatherer = NewRegistry()

func NewRegistry() *prometheus.Registry {
r := prometheus.NewRegistry()

// default registers
r.MustRegister(
collectors.NewGoCollector(
collectors.WithGoCollectorRuntimeMetrics(
collectors.MetricsGC,
collectors.MetricsScheduler,
collectors.MetricsMemory,
collectors.GoRuntimeMetricsRule{Matcher: regexp.MustCompile(`^/sync/.*`)},
),
),
collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}),
)
return r
}
Loading