Skip to content

🐛 Fix race in logger test #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2025
Merged

🐛 Fix race in logger test #3150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pkg/manager/manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,9 +1092,14 @@ var _ = Describe("manger.Manager", func() {
msg := "controller log message"
m.GetControllerOptions().Logger.Info(msg)

Expect(messages).To(ContainElement(
ContainSubstring(msg),
))
Eventually(func(g Gomega) {
Copy link
Member Author

@sbueringer sbueringer Mar 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we had a race condition here I assume it's also necessary to use Eventually

lock.Lock()
defer lock.Unlock()

g.Expect(messages).To(ContainElement(
ContainSubstring(msg),
))
}).Should(Succeed())
})

It("should return both runnables and stop errors when both error", func() {
Expand Down
Loading