🌱 Certwatcher: Don't require leaderelection #3273
Merged
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign |
Controller-Runtime starts the certwatcher in the webhook server, which means it always runs regardless of the current replica being leader or not. It turns out that kubebuilder adds it to the manager and as a result, it only runs on leader replicas. Make it a `LeaderElectionRunnable` and don't require leader election so that it will work correctly even if other projects use it in ways that were not originally anticipated.
alvaroaleman
force-pushed
the
certwatcher-le
branch
from
f6b98e2 to
4dfefb0
Compare
|
I didn't realize that cert watcher implements the Runnable interface. I hope it works correctly used as a Runnable, but I don't see anything obvious why it wouldn't /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 43b3f20ae7c738e3850e83b80d6c1760f7f0cf1a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Controller-Runtime starts the certwatcher in the webhook server, which means it always runs regardless of the current replica being leader or not.
It turns out that kubebuilder adds it to the manager and as a result, it only runs on leader replicas. Make it a
LeaderElectionRunnableand don't require leader election so that it will work correctly even if other projects use it in ways that were not originally anticipated.