🐛 Fakeclient: Validate managed fields on init objects #3282
+108
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the FieldManager in the FieldManagedObjectTracker encounters managed fields it can not decode, it will just silently clear them. This breaks anyone who has tests where the fakeclient gets initialized with objects that have invalid managed fields. This worked prior to using the `FieldManagedObjectTracker`, as the default `testing.ObjectTracker` we used before has no understanding of them. Validate the `managedFields` during fake client initialization to make this issue properly visible.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
Thank you! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 40ca5b1f74ce4a2047c86d70dddd9815b480fa1c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the FieldManager in the FieldManagedObjectTracker encounters managed fields it can not decode, it will just silently clear them.
This breaks anyone who has tests where the fakeclient gets initialized with objects that have invalid managed fields. This worked prior to using the
FieldManagedObjectTracker, as the defaulttesting.ObjectTrackerwe used before has no understanding of them.Validate the
managedFieldsduring fake client initialization to make this issue properly visible.As an alternative to this patch I had initially considered to just try fix them up. That would however require that the fake client understands what constitutes valid managedFields and how they can be fixed up, which might not always be clear and would end up being pretty magic. Thus we just import the validation code and let the user know.