⚠️ Priorityqueue: Make priority opt a pointer #3289
Merged
+41
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
alvaroaleman
changed the title
Making the priority opt a pointer allows to dinstinguish "unset" from "0". While this is irrelevant for the priorityqueue itself, it is required for any wrapper that wants to inject a default priority without overriding one that was explicitly set.
sbueringer
reviewed
Aug 19, 2025
| @@ -136,7 +136,7 @@ func (h TypedFuncs[object, request]) Create(ctx context.Context, e event.TypedCr | |||
| priority = LowPriority | |||
| } | |||
| q.(priorityqueue.PriorityQueue[request]).AddWithOpts( | |||
| priorityqueue.AddOpts{Priority: priority}, | |||
| priorityqueue.AddOpts{Priority: &priority}, | |||
There was a problem hiding this comment.
Should this only be set if IsInInitialList is true?
(currently we otherwise set it to &0)
(same below)
| @@ -888,7 +888,10 @@ var _ = Describe("Eventhandler", func() { | |||
| IsInInitialList: false, | |||
| }, wq) | |||
|
|
|||
| Expect(actualOpts).To(Equal(priorityqueue.AddOpts{})) | |||
| Expect(actualOpts).To(Or( | |||
| Equal(priorityqueue.AddOpts{}), | |||
There was a problem hiding this comment.
Wondering if &0 is correct here
(similar below)
|
I think my findings are addressed in #3290 /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ab67793043706cbe1cb2c8b235fb7f9bdc2b6d3d
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the priority opt a pointer allows to dinstinguish "unset" from "0". While this is irrelevant for the priorityqueue itself, it is required for any wrapper that wants to inject a default priority without overriding one that was explicitly set.