Skip to content

📖 Clarify state of Warmup feature #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
+10 −2
Merged

📖 Clarify state of Warmup feature #3299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/config/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,16 @@ type Controller struct {
// Setting EnableWarmup to true and NeedLeaderElection to false is a no-op as controllers without
// leader election do not wait on leader election to start their sources.
// Defaults to false.
//
// Note: This feature is currently in beta and subject to change.
// For more details, see: https://github.com/kubernetes-sigs/controller-runtime/issues/3220.
EnableWarmup *bool

// UsePriorityQueue configures the controllers queue to use the controller-runtime provided
// priority queue.
//
// Note: This flag is disabled by default until a future version. It's currently in beta.
// Note: This flag is disabled by default until a future version. This feature is currently in beta.
// For more details, see: https://github.com/kubernetes-sigs/controller-runtime/issues/2374.
UsePriorityQueue *bool

// Logger is the logger controllers should use.
Expand Down
6 changes: 5 additions & 1 deletion pkg/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ type TypedOptions[request comparable] struct {
// UsePriorityQueue configures the controllers queue to use the controller-runtime provided
// priority queue.
//
// Note: This flag is disabled by default until a future version. It's currently in beta.
// Note: This flag is disabled by default until a future version. This feature is currently in beta.
// For more details, see: https://github.com/kubernetes-sigs/controller-runtime/issues/2374.
UsePriorityQueue *bool

// EnableWarmup specifies whether the controller should start its sources when the manager is not
Expand All @@ -105,6 +106,9 @@ type TypedOptions[request comparable] struct {
// Setting EnableWarmup to true and NeedLeaderElection to false is a no-op as controllers without
// leader election do not wait on leader election to start their sources.
// Defaults to false.
//
// Note: This feature is currently in beta and subject to change.
// For more details, see: https://github.com/kubernetes-sigs/controller-runtime/issues/3220.
EnableWarmup *bool

// ReconciliationTimeout is used as the timeout passed to the context of each Reconcile call.
Expand Down