✨crd/marker: add AtLeastOneOf constraint

[shashankram]

• Adds AtLeastOneOf marker which is similar to AtMostOneOf and ExactlyOneOf markers.
• Ensures relative ordering between XValidation and *OneOf markers are deterministic.
• Part of CRD validation marker for AtLeastOneOf constraints #1272

[k8s-ci-robot]

Hi @shashankram. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[shashankram]

cc @JoelSpeed @alvaroaleman who reviewed #1212

[JoelSpeed]

@shashankram Would you mind splitting this PR in two? Moving to ginkgo v2 is definitely something we should do, but lets not muddle it with the rest of this PR, they should be separate

[shashankram]

@shashankram Would you mind splitting this PR in two? Moving to ginkgo v2 is definitely something we should do, but lets not muddle it with the rest of this PR, they should be separate

@JoelSpeed done

[JoelSpeed]

@shashankram Did you create a separate PR for the ginkgo v2 stuff? If you haven't, are you able to?

Also please make sure to update the PR description

[JoelSpeed]

In theory, in a lot of cases, adding a MinProperties would be sufficient wouldn't it? You'd be able to specify that at least one property must be set on the object?

This is helpful though in the case where you've mixed your fields with other fields and you need at least one of them, without caring about their siblings?

[JoelSpeed]

To match the others?

Suggested change

	type TypeWithAllOneofs struct {
	type TypeWithAllOneOfs struct {

[shashankram]

It currently matches the casing with other type names

[JoelSpeed]

Oh, odd, I thought we should have gone with OneOf, i was suggesting to align to the comment lines 84-86. We probably should have done that casing for the previous cases as well

[shashankram]

I don't want to increase the scope of this PR, given that has been an issue with other renames/formatting in previous PRs of mine. Let's keep this as-is since it has no functional effects

[shashankram]

In theory, in a lot of cases, adding a MinProperties would be sufficient wouldn't it? You'd be able to specify that at least one property must be set on the object?

This is helpful though in the case where you've mixed your fields with other fields and you need at least one of them, without caring about their siblings?

Yes, this is quite a common scenario so this marker would be useful.

[shashankram]

@shashankram Did you create a separate PR for the ginkgo v2 stuff? If you haven't, are you able to?

I'll open a separate PR once this merges

[shashankram]

@JoelSpeed this should be good to merge

[sbueringer]

/assign

I'll take a look once Joel lgtm's

[sbueringer]

/ok-to-test

[JoelSpeed]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: b63c502c717b5c4cff890eb0cadba775e992ef5d

[sbueringer]

Thank you!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, shashankram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment