🌱 use modernize linter #1300

HaraldNordgren · 2025-10-30T15:54:34Z

No description provided.

k8s-ci-robot · 2025-10-30T15:55:01Z

Hi @HaraldNordgren. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoelSpeed · 2025-10-30T17:51:21Z

/ok-to-test

Is there a linter we can use to prevent people using this old style?

HaraldNordgren · 2025-11-01T11:42:50Z

/retest

HaraldNordgren · 2025-11-01T14:57:55Z

pkg/applyconfiguration/applyconfiguration_integration_test.go

 			content = []byte(strings.ReplaceAll(string(content), "testdata/cronjob/api/v1/applyconfiguration", filepath.Join("testdata/cronjob/api/v1", outputPackage)))

+			// Make sure the interface{} is replaced with any.
+			content = []byte(strings.ReplaceAll(string(content), "any", "interface{}"))


I don't understand why this is necessary, it's causes by my changing the signature of ForKind. But it's not clear to me why I can't get Golang to just output "any" on the generated code.

HaraldNordgren · 2025-11-14T20:29:11Z

Hi @JoelSpeed, there is the modernize linter which I added now, it required me to change more than I expected.

Do you think it's a good change?

JoelSpeed

Where code is being generated by upstream generators (applyconfiguration) I don't think it makes sense to apply these rules so lets have an exception, otherwise I think this is fine

Any opinions @sbueringer or @alvaroaleman ?

pkg/applyconfiguration/testdata/cronjob/api/v1/applyconfiguration/utils.go

HaraldNordgren · 2025-11-15T20:20:40Z

@JoelSpeed Reverted that change now 👍

JoelSpeed · 2025-11-16T15:02:30Z

@HaraldNordgren It seems the linting check is passing, though I don't see an exception for the generated files. Are we excluding the generated files already somehow?

sbueringer · 2025-11-24T16:38:38Z

Where code is being generated by upstream generators (applyconfiguration) I don't think it makes sense to apply these rules so lets have an exception, otherwise I think this is fine

Any opinions @sbueringer or @alvaroaleman ?

Agree. Generated code should be excluded

dongjiang1989

LGTM

k8s-ci-robot · 2025-12-01T09:46:50Z

@dongjiang1989: changing LGTM is restricted to collaborators

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoelSpeed · 2025-12-04T15:49:57Z

/label tide/merge-method-squash
/lgtm
/approve

k8s-ci-robot · 2025-12-04T15:50:06Z

LGTM label has been added.

Details

Git tree hash: 6108f9ad63ea98870465a75e81f98fb64a19e121

k8s-ci-robot · 2025-12-04T15:50:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dongjiang1989, HaraldNordgren, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 30, 2025

HaraldNordgren changed the title ~~modernize for loops~~ modernize counting loops Oct 30, 2025

k8s-ci-robot requested review from alvaroaleman and vincepri October 30, 2025 15:54

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 30, 2025

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2025

HaraldNordgren changed the title ~~modernize counting loops~~ 🌱 modernize counting loops Oct 30, 2025

HaraldNordgren changed the title ~~🌱 modernize counting loops~~ 🌱 modernize loops Oct 30, 2025

HaraldNordgren marked this pull request as ready for review October 30, 2025 16:47

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025

k8s-ci-robot requested a review from chrischdi October 30, 2025 16:47

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2025

HaraldNordgren force-pushed the main branch from 14b8b12 to 7741535 Compare November 1, 2025 11:38

HaraldNordgren force-pushed the main branch from 7741535 to 61443b1 Compare November 1, 2025 12:14

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2025

HaraldNordgren force-pushed the main branch from 61443b1 to 66d97d7 Compare November 1, 2025 12:23

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2025

HaraldNordgren force-pushed the main branch from 66d97d7 to 70f8d80 Compare November 1, 2025 12:24

HaraldNordgren closed this Nov 1, 2025

HaraldNordgren force-pushed the main branch from 70f8d80 to 9fb4c06 Compare November 1, 2025 12:25

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2025

HaraldNordgren force-pushed the main branch from d430974 to 8da5b6b Compare November 1, 2025 12:31

HaraldNordgren changed the title ~~🌱 modernize loops~~ 🌱 use modernize linter Nov 1, 2025

HaraldNordgren force-pushed the main branch 4 times, most recently from e282e18 to 9509357 Compare November 1, 2025 14:50

HaraldNordgren commented Nov 1, 2025

View reviewed changes

JoelSpeed reviewed Nov 15, 2025

View reviewed changes

pkg/applyconfiguration/testdata/cronjob/api/v1/applyconfiguration/utils.go Outdated Show resolved Hide resolved

HaraldNordgren force-pushed the main branch from 9978929 to b42a0f3 Compare November 15, 2025 19:24

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2025

dongjiang1989 approved these changes Dec 1, 2025

View reviewed changes

HaraldNordgren added 2 commits December 1, 2025 12:48

🌱 use modernize linter

ee82eea

revert generated code

fb752bc

HaraldNordgren force-pushed the main branch from b42a0f3 to fb752bc Compare December 1, 2025 11:49

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025

HaraldNordgren requested a review from JoelSpeed December 2, 2025 13:10

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 4, 2025

k8s-ci-robot assigned JoelSpeed Dec 4, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2025

k8s-ci-robot merged commit 2f0db50 into kubernetes-sigs:main Dec 4, 2025
9 checks passed

jackfrancis mentioned this pull request Jan 8, 2026

chore: update controller-gen to v0.20.0 kubernetes-sigs/cluster-api-provider-azure#6029

Closed

4 tasks

🌱 use modernize linter #1300

🌱 use modernize linter #1300

Conversation

HaraldNordgren commented Oct 30, 2025

Uh oh!

k8s-ci-robot commented Oct 30, 2025

Uh oh!

JoelSpeed commented Oct 30, 2025

Uh oh!

HaraldNordgren commented Nov 1, 2025

Uh oh!

HaraldNordgren Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

HaraldNordgren commented Nov 14, 2025

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HaraldNordgren commented Nov 15, 2025

Uh oh!

JoelSpeed commented Nov 16, 2025

Uh oh!

sbueringer commented Nov 24, 2025

Uh oh!

dongjiang1989 left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Dec 1, 2025

Uh oh!

JoelSpeed commented Dec 4, 2025

Uh oh!

k8s-ci-robot commented Dec 4, 2025

Uh oh!

k8s-ci-robot commented Dec 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants