Non-breaking feature: ✨ deepcopy - do not generate empty import

[ivankatliarchuk]

Controller-gen was generating empty import () blocks in DeepCopy files when types didn't require external dependencies

Modified the writeHeader function to conditionally generate import blocks:

• Added logic to check if importSpecs has any entries before writing the import block
• Prevents generation of empty import () statements

Create unit test Unit Tests.

Added comprehensive E2E test that:

• Generates actual deepcopy code from real Go source files
• Verifies no empty import blocks exist in output
• Confirms no import statement appears when unnecessary
• Compares generated output with expected golden file

Before (with empty imports):

  package simpletypes

  import ()

  // DeepCopyInto is an autogenerated deepcopy function...

After (clean output):

  package simpletypes

  // DeepCopyInto is an autogenerated deepcopy function...

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivankatliarchuk
Once this PR has been reviewed and has the lgtm label, please assign alvaroaleman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ivankatliarchuk]

/retest

[JoelSpeed]

Why is this so late? Surely you want to check this straight after the Run, else the rest of the test doesn't make a lot of sense?

[ivankatliarchuk]

I copied same pattern as in other test

controller-tools/pkg/deepcopy/deepcopy_integration_test.go

Line 105 in 60c448e

Expect(hadErrs).To(BeFalse())

. Moved up

[JoelSpeed]

Would it normally do import () or import( with a newline before the closing )?

[ivankatliarchuk]

Resolved. As currently it is import ()