-
Notifications
You must be signed in to change notification settings - Fork 87
Update RELEASE.md #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RELEASE.md #121
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| SHA digests and tags of the new artifacts from the staging repo | ||
| - Example PR: https://github.com/kubernetes/k8s.io/pull/7871 | ||
| 1. The artifacts are verified to be available from registry.k8s.io | ||
| 1. The artifacts are verified to be available from registry.k8s.io: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also suggested we test the promoted artifacts after this step, but there isn't an easy way to do that without hacking around the existing scripts to run the e2e tests. I'll open an issue to track enabling that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The issue should describe if one or both of the container image and Helm | ||
| chart should be released. | ||
| - Example issue: https://github.com/kubernetes-sigs/dra-example-driver/issues/119 | ||
| 1. At least two of the [OWNERS](OWNERS) must agree to move forward with this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to explain how they must agree and if release PR author is counted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to specify any formal mechanism here. The only thing this is trying to prevent is any single person from pushing through a release totally by themselves.
|
/hold for squash |
|
/lgtm |
8a6806f to
a02b3e6
Compare
|
Squashed! @bart0sh one more quick lgtm would be great, thanks! /hold cancel |
|
/lgtm |
This PR incorporates feedback from @bart0sh as we cut the v0.2.0 release.
Real-time discussion as we were cutting the release for posterity: https://kubernetes.slack.com/archives/C0409NGC1TK/p1756330903622829