Skip to content

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Aug 28, 2025

This PR incorporates feedback from @bart0sh as we cut the v0.2.0 release.

Real-time discussion as we were cutting the release for posterity: https://kubernetes.slack.com/archives/C0409NGC1TK/p1756330903622829

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 28, 2025
@k8s-ci-robot k8s-ci-robot requested a review from bart0sh August 28, 2025 17:50
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from byako August 28, 2025 17:50
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2025
SHA digests and tags of the new artifacts from the staging repo
- Example PR: https://github.com/kubernetes/k8s.io/pull/7871
1. The artifacts are verified to be available from registry.k8s.io
1. The artifacts are verified to be available from registry.k8s.io:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggested we test the promoted artifacts after this step, but there isn't an easy way to do that without hacking around the existing scripts to run the e2e tests. I'll open an issue to track enabling that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue should describe if one or both of the container image and Helm
chart should be released.
- Example issue: https://github.com/kubernetes-sigs/dra-example-driver/issues/119
1. At least two of the [OWNERS](OWNERS) must agree to move forward with this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to explain how they must agree and if release PR author is counted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify any formal mechanism here. The only thing this is trying to prevent is any single person from pushing through a release totally by themselves.

@pohly pohly moved this from 🆕 New to 👀 In review in Dynamic Resource Allocation Aug 29, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 10, 2025

/hold for squash

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2025
@bart0sh
Copy link
Contributor

bart0sh commented Sep 11, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2025
@nojnhuh nojnhuh force-pushed the update-release-guide branch from 8a6806f to a02b3e6 Compare September 11, 2025 16:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2025
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 11, 2025

Squashed! @bart0sh one more quick lgtm would be great, thanks!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2025
@bart0sh
Copy link
Contributor

bart0sh commented Sep 11, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2025
@bart0sh bart0sh merged commit ba82bf5 into kubernetes-sigs:main Sep 11, 2025
5 of 6 checks passed
@nojnhuh nojnhuh deleted the update-release-guide branch September 11, 2025 19:12
@pohly pohly moved this from 👀 In review to ✅ Done in Dynamic Resource Allocation Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants