Add config for staging repo image build#77
Conversation
pohly
left a comment
There was a problem hiding this comment.
This looks similar to things I did with cloudbuild in the past, but I don't remember enough to determine upfront whether it will work.
Has this been tested manually somehow or do we need to merge and then check whether it works?
I tried invoking the scripts that this runs, but I didn't try actually feeding it to cloudbuild. I expect that when this PR and kubernetes/test-infra#34376 merge, then subsequent merges to main in this repo will trigger the job and we'll see results on testgrid. I put a hold on the test-infra PR to wait for this PR to merge first, but maybe if we time it so this PR merges right after that one, then we can get some immediate feedback whether or not it's working as expected. In the meantime I can try to trigger a build locally if that's acceptable, but I haven't touched any Google Cloud things before so please let me know if there's any damage I'm able to do that I should avoid. 😄 |
|
Let's get that merged first.
You would need the right credentials, so it probably simply wouldn't work. Let's merge and try it in the real environment. |
|
kubernetes/test-infra#34376 got merged. Let's proceed... /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It failed for commit 4ed5279 which is the merge commit for this PR: There's a name mismatch: the error is about |
|
Let's rename the file. |
|
Done: #78 |
|
The job passed now but created a v0.1.0 tag where I was expecting just the commit SHA, so I'll take a look to see why that's happening. |
This PR adds a cloudbuild.yaml which serves as input to kubernetes/test-infra#34376 which defines how images should be built and pushed to the new staging repo added by kubernetes/k8s.io#7703.
Part of #64