-
Notifications
You must be signed in to change notification settings - Fork 109
feat: handle path list for kubeconfig env var #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ndbaker1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @ndbaker1! |
Hi @ndbaker1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @ndbaker1 thanks for this PR.
Thanks. |
bcd9589
to
e7f5b15
Compare
thanks for looking @vladimirvivien! i added unit tests with my latest revision and improved the PR overview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndbaker1 this looks good. Please add an example markdown doc.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR implement simple parsing of
$KUBECONFIG
as a path list, similar to how it is done in client-go:this allows users to do things like pickup a directory-scoped kubeconfig as well as the home directory fallback using the following config:
KUBECONFIG=.kube/config:~/.kube/config
Testing
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., Usage docs, etc.: