feat: expose DeleteOptions in envfuncs.DeleteNamespace #537
Conversation
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cartermckinnon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
|
@harshanarayana can you take a look at this one? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@vladimirvivien are you still an approver here? |
vladimirvivien
left a comment
vladimirvivien
left a comment
There was a problem hiding this comment.
This looks good @cartermckinnon . Since it is changing the signature, please add some tests.
| // namespace. It first searches for the ns in its context, if not found then | ||
| // attempt to retrieve it from the API server. Then deletes it. | ||
| func DeleteNamespace(name string) env.Func { | ||
| func DeleteNamespace(name string, opts ...resources.DeleteOption) env.Func { |
There was a problem hiding this comment.
This should be backward compatible. However, please add some tests.
4 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
I want to delete a test's namespace in the foreground, to ensure the namespace is not left
Terminatingafter the test completes.I've exposed the
resources.DeleteOptionsto make this possible usingresources.WithDeletePropagation.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., Usage docs, etc.: