Skip to content

feat: add support for ingress backed GlooEdge Gateway #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add support for ingress backed GlooEdge Gateway #5909

wants to merge 1 commit into from
+344 −20

Conversation

cucxabong
Copy link

@cucxabong cucxabong commented Oct 16, 2025 •
edited
Loading

What does it do ?

fix #5908

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @cucxabong!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 16, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @cucxabong. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added source size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2025
@cucxabong cucxabong force-pushed the feat/gloo-gateway-ingress-annotation branch 3 times, most recently from da56738 to c996a08 Compare October 16, 2025 17:01
@AndrewCharlesHay
Copy link
Contributor

lgtm

@cucxabong cucxabong force-pushed the feat/gloo-gateway-ingress-annotation branch from c996a08 to a8c674c Compare October 17, 2025 06:12
ivankatliarchuk
ivankatliarchuk suggested changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it tested on real cluster? What was your kubernetes manifests and results?

docs/annotations/annotations.md
However, in some setups, the Gateway's Service is of type ClusterIP, with all public traffic routed to it via a separate Kubernetes Ingress object. This setup leaves the Gateway without a public IP that ExternalDNS can discover.

- **The Solution**: The annotation on the Istio Gateway tells ExternalDNS to ignore the Gateway's Service IP. Instead, it directs ExternalDNS to a specified Ingress resource to find the target LoadBalancer IP address.
- **The Solution**: The annotation on the Istio/GlooEdge Gateway tells ExternalDNS to ignore the Gateway's Service IP. Instead, it directs ExternalDNS to a specified Ingress resource to find the target LoadBalancer IP address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add at least single use case? Example https://github.com/kubernetes-sigs/external-dns/blob/master/docs/annotations/annotations.md#use-cases-for-external-dnsalphakubernetesiohostname-annotation

Copy link
Author

@cucxabong cucxabong Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added our use case

@ivankatliarchuk
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2025
@coveralls
Copy link

coveralls commented Oct 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18590290273

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 33 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 78.548%
Files with Coverage Reduction New Missed Lines %
gloo_proxy.go 33 74.66%
Totals Coverage Status
Change from base Build 18457751024: -0.03%
Covered Lines: 15869
Relevant Lines: 20203
💛 - Coveralls

@cucxabong cucxabong force-pushed the feat/gloo-gateway-ingress-annotation branch from a8c674c to f9dec1c Compare October 17, 2025 10:37
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ivankatliarchuk. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cucxabong
Copy link
Author

@ivankatliarchuk yes, I did a test on our sandbox env in dry-run mode and observed the expected behaviour

@cucxabong cucxabong force-pushed the feat/gloo-gateway-ingress-annotation branch from f9dec1c to 3b2a8e7 Compare October 17, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szuecs szuecs Awaiting requested review from szuecs

1 more reviewer

@ivankatliarchuk ivankatliarchuk ivankatliarchuk requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ivankatliarchuk ivankatliarchuk

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support ingress backed Gloo Proxy

5 participants

@cucxabong @k8s-ci-robot @AndrewCharlesHay @ivankatliarchuk @coveralls