Skip to content

feat(coredns): rename ownerId and ownedBy to owner #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jan 10, 2026
Merged

feat(coredns): rename ownerId and ownedBy to owner #6032

k8s-ci-robot merged 1 commit into from
Jan 10, 2026

Conversation

@farodin91
Copy link
Contributor

@farodin91 farodin91 commented Dec 17, 2025

What does it do ?

  • Rename all usage of any owner variant to owner
  • Set the label to owner from the field (reduce confuse)

Motivation

We looked again into the code were a bit confused about naming as we had ownerID, ownedBy, and owner.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. provider Issues or PRs related to a provider needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 17, 2025

Hi @farodin91. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2025
@farodin91
Copy link
Contributor Author

farodin91 commented Dec 17, 2025

@ivankatliarchuk I thought to make this PR as fast as possible. My commit isn't released yet.

@mloiseleur
Copy link
Collaborator

mloiseleur commented Dec 19, 2025

/ok-to-test

@farodin91 It looks like a breaking change. Is it?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 19, 2025
@farodin91
Copy link
Contributor Author

farodin91 commented Dec 19, 2025 •
edited
Loading

@mloiseleur Yes, but the original change wasn't released yet. #5921

@farodin91
feat(coredns): rename ownerId and ownedBy to owner
6bcdb47 
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
@coveralls
Copy link

coveralls commented Dec 19, 2025

Pull Request Test Coverage Report for Build 20372499713

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on rename-owner at 78.704%
Totals Coverage Status
Change from base Build 20368853975: 78.7%
Covered Lines: 16028
Relevant Lines: 20365
💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 19, 2025

Pull Request Test Coverage Report for Build 20370815806

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on rename-owner at 78.704%
Totals Coverage Status
Change from base Build 20368853975: 78.7%
Covered Lines: 16028
Relevant Lines: 20365
💛 - Coveralls

ivankatliarchuk
ivankatliarchuk suggested changes Dec 23, 2025
View reviewed changes
provider/coredns/coredns.go
}
log.Debugf("Creating new ep (%s) with new service host (%s)", ep, service.Host)
}
if p.strictlyOwned {
Copy link
Member

@ivankatliarchuk ivankatliarchuk Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not too clear why this if is required

Copy link
Contributor Author

@farodin91 farodin91 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this label to make it more consistent. Also, if Service with a txt record exists this will preferred.

Copy link
Contributor Author

@farodin91 farodin91 Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could remove it or move it into an extra pr.

provider/coredns/coredns.go
endpoint.RecordTypeTXT,
service.Text,
)
if p.strictlyOwned {
Copy link
Member

@ivankatliarchuk ivankatliarchuk Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, why if is required?

@ivankatliarchuk
Copy link
Member

ivankatliarchuk commented Jan 9, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2026
mloiseleur
mloiseleur reviewed Jan 10, 2026
View reviewed changes
Copy link
Collaborator

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2026
@k8s-ci-robot k8s-ci-robot merged commit 63296f5 into kubernetes-sigs:master Jan 10, 2026
18 checks passed
farodin91 added a commit to GDATASoftwareAG/external-dns-coredns-webhook that referenced this pull request Jan 12, 2026
@farodin91
Merge kubernetes-sigs/external-dns#6032 into webhook
45b57a9 
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
farodin91 added a commit to GDATASoftwareAG/external-dns-coredns-webhook that referenced this pull request Jan 12, 2026
@farodin91
Merge kubernetes-sigs/external-dns#6032 into webhook
918ccc5 
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
farodin91 added a commit to GDATASoftwareAG/external-dns-coredns-webhook that referenced this pull request Jan 12, 2026
@farodin91
Merge kubernetes-sigs/external-dns#6032 into webhook
ea6e7bb 
Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Jan 16, 2026
@ivankatliarchuk
Merge branch 'master' into chore-standartize-source-constructors
ebf47a6 
* master: (25 commits)
  feat(event): standardize event messages and add resource kind lookup for events (kubernetes-sigs#6101)
  refactor(informers): unify cache sync functions using generics (kubernetes-sigs#6102)
  fix(fqdn): support kind and api version (kubernetes-sigs#6097)
  test(fqdn): cover sources without any fqdn tests (kubernetes-sigs#6094)
  chore(tools): CRD generation script moved and add validation workflow (kubernetes-sigs#6079)
  fix(metrics): add CNAME to known record types (kubernetes-sigs#6115)
  chore(cloudflare): migrate customhostname to v5 (kubernetes-sigs#5891)
  test(provider/exoscale): improved the test coverage for exoscale provider from 62.8% to 80.4%  (kubernetes-sigs#6112)
  feat(source): gateway api hostname source annotation (kubernetes-sigs#5959)
  test: cover pkg/events/fake package (kubernetes-sigs#6096)
  refactor(controller): controller no longer responsible for SingletonClientGenerator creation (kubernetes-sigs#6077)
  refactor(source): standardize FQDN template accross sources (kubernetes-sigs#6093)
  feat(coredns): rename ownerId and ownedBy to owner (kubernetes-sigs#6032)
  docs: fix typo in README (The are → There are) (kubernetes-sigs#6095)
  refactor(aws): abstract provider-specific boolean parsing (kubernetes-sigs#6078)
  refactor(api): deduplicate addKnownTypes (kubernetes-sigs#6087)
  fix(api): rollback changes for omitempty (kubernetes-sigs#6086)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#6080)
  fix(aws): enable AWS API validation for routing policies without setIdentifier (kubernetes-sigs#6082)
  chore(aws): document and test behavior for ALB and NLB (kubernetes-sigs#6063)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mloiseleur mloiseleur mloiseleur left review comments

@szuecs szuecs Awaiting requested review from szuecs

@vflaux vflaux Awaiting requested review from vflaux

+1 more reviewer

@ivankatliarchuk ivankatliarchuk ivankatliarchuk requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ivankatliarchuk ivankatliarchuk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. provider Issues or PRs related to a provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@farodin91 @k8s-ci-robot @mloiseleur @coveralls @ivankatliarchuk