Skip to content

refactor(controller): controller no longer responsible for SingletonClientGenerator creation #6077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 8 commits into from
Jan 10, 2026
Merged

refactor(controller): controller no longer responsible for SingletonClientGenerator creation #6077

k8s-ci-robot merged 8 commits into from
Jan 10, 2026

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented Jan 2, 2026 •
edited
Loading

What does it do ?

Controller to focus on orchestration. Reduces a mix of responsibilities.

Motivation

Slicing PR #6076

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@ivankatliarchuk
refactore(controller): abstract things that should not be in controller
09a6574 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk marked this pull request as draft January 2, 2026 12:06
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2026
@k8s-ci-robot k8s-ci-robot requested a review from szuecs January 2, 2026 12:06
@k8s-ci-robot k8s-ci-robot added the controller Issues or PRs related to the controller label Jan 2, 2026
@k8s-ci-robot k8s-ci-robot requested a review from vflaux January 2, 2026 12:06
@k8s-ci-robot k8s-ci-robot added source size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 2, 2026
@ivankatliarchuk
refactore(controller): abstract things that should not be in controller
417b7ed 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2026
@ivankatliarchuk
refactore(controller): abstract things that should not be in controller
fe3e0e6 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@coveralls
Copy link

coveralls commented Jan 2, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 20775819698

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 179 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 78.896%
Files with Coverage Reduction New Missed Lines %
execute.go 40 60.78%
store.go 139 44.09%
Totals Coverage Status
Change from base Build 20774403164: -0.002%
Covered Lines: 15903
Relevant Lines: 20157
💛 - Coveralls

@ivankatliarchuk
refactore(controller): abstract things that should not be in controller
2de9f52 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk marked this pull request as ready for review January 2, 2026 13:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2026
@ivankatliarchuk
refactore(controller): abstract things that should not be in controller
d52e74d 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk
refactore(controller): abstract things that should not be in controller
11b682d 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk changed the title refactore(controller): abstract things that should not be in controller refactore(controller): remove SingletonClientGenerator creation from controller Jan 2, 2026
ivankatliarchuk
ivankatliarchuk commented Jan 2, 2026
View reviewed changes
@ivankatliarchuk ivankatliarchuk changed the title refactore(controller): remove SingletonClientGenerator creation from controller refactore(controller): move responsibility to create SingletonClientGenerator Jan 2, 2026
@ivankatliarchuk
refactore(controller): abstract things that should not be in controller
b281839 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk changed the title refactore(controller): move responsibility to create SingletonClientGenerator refactore(controller): conroller no longer responsible for SingletonClientGenerator creation Jan 2, 2026
@mloiseleur mloiseleur changed the title refactore(controller): conroller no longer responsible for SingletonClientGenerator creation refactore(controller): controller no longer responsible for SingletonClientGenerator creation Jan 2, 2026
@mloiseleur mloiseleur changed the title refactore(controller): controller no longer responsible for SingletonClientGenerator creation refactor(controller): controller no longer responsible for SingletonClientGenerator creation Jan 2, 2026
@ivankatliarchuk
refactore(controller): abstract things that should not be in controller
df051d4 
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
mloiseleur
mloiseleur reviewed Jan 10, 2026
View reviewed changes
Copy link
Collaborator

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2026
@ivankatliarchuk
Copy link
Member Author

ivankatliarchuk commented Jan 10, 2026

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2026
@k8s-ci-robot k8s-ci-robot merged commit 56fb17a into kubernetes-sigs:master Jan 10, 2026
18 checks passed
@ivankatliarchuk ivankatliarchuk mentioned this pull request Jan 11, 2026
Open
3 tasks
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Jan 16, 2026
@ivankatliarchuk
Merge branch 'master' into chore-standartize-source-constructors
ebf47a6 
* master: (25 commits)
  feat(event): standardize event messages and add resource kind lookup for events (kubernetes-sigs#6101)
  refactor(informers): unify cache sync functions using generics (kubernetes-sigs#6102)
  fix(fqdn): support kind and api version (kubernetes-sigs#6097)
  test(fqdn): cover sources without any fqdn tests (kubernetes-sigs#6094)
  chore(tools): CRD generation script moved and add validation workflow (kubernetes-sigs#6079)
  fix(metrics): add CNAME to known record types (kubernetes-sigs#6115)
  chore(cloudflare): migrate customhostname to v5 (kubernetes-sigs#5891)
  test(provider/exoscale): improved the test coverage for exoscale provider from 62.8% to 80.4%  (kubernetes-sigs#6112)
  feat(source): gateway api hostname source annotation (kubernetes-sigs#5959)
  test: cover pkg/events/fake package (kubernetes-sigs#6096)
  refactor(controller): controller no longer responsible for SingletonClientGenerator creation (kubernetes-sigs#6077)
  refactor(source): standardize FQDN template accross sources (kubernetes-sigs#6093)
  feat(coredns): rename ownerId and ownedBy to owner (kubernetes-sigs#6032)
  docs: fix typo in README (The are → There are) (kubernetes-sigs#6095)
  refactor(aws): abstract provider-specific boolean parsing (kubernetes-sigs#6078)
  refactor(api): deduplicate addKnownTypes (kubernetes-sigs#6087)
  fix(api): rollback changes for omitempty (kubernetes-sigs#6086)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#6080)
  fix(aws): enable AWS API validation for routing policies without setIdentifier (kubernetes-sigs#6082)
  chore(aws): document and test behavior for ALB and NLB (kubernetes-sigs#6063)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mloiseleur mloiseleur mloiseleur left review comments

@szuecs szuecs Awaiting requested review from szuecs

@vflaux vflaux Awaiting requested review from vflaux

Assignees

@mloiseleur mloiseleur

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. controller Issues or PRs related to the controller lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ivankatliarchuk @coveralls @k8s-ci-robot @mloiseleur