Skip to content

chore(tools): CRD generation script moved and add validation workflow #6079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ivankatliarchuk wants to merge 10 commits into
base: master
Choose a base branch
from
Open

chore(tools): CRD generation script moved and add validation workflow #6079

ivankatliarchuk wants to merge 10 commits into from
+162 −12

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented Jan 4, 2026 •
edited
Loading

What does it do ?

  • Extract CRD generation logic into scripts/generate-crd.sh for better maintainability (required in makefile and github action)
  • Add CI workflow to validate CRD files are up-to-date and when go.tool.mod changes
  • Add make tools-deps target to update tool dependencies

Follow-up

  • update tools version and validate regenerated CRD (latest controller-gen may produce new changes)

Motivation

  • Different controller-gen versions produce different output
  • Ensures generated files stay in sync with tool dependencies
  • Prevents CI failures from stale generated code
  • Provides make tools-deps until Dependabot supports go.tool.mod (#12050)

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from szuecs and vflaux January 4, 2026 17:21
@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. scripts Issues or PRs related to internal scripts size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2026
@ivankatliarchuk ivankatliarchuk changed the title chore(tools): refactor CRD generation and add validation workflow chore(tools): CRD generation script change and add validation workflow Jan 4, 2026
@coveralls
Copy link

coveralls commented Jan 4, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 20810902671

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.899%
Totals Coverage Status
Change from base Build 20810601084: 0.0%
Covered Lines: 15895
Relevant Lines: 20146
💛 - Coveralls

@ivankatliarchuk ivankatliarchuk force-pushed the chore-tools branch 3 times, most recently from 37a5a67 to 13d0bcd Compare January 4, 2026 17:40
vflaux
vflaux suggested changes Jan 5, 2026
View reviewed changes
@ivankatliarchuk ivankatliarchuk requested a review from vflaux January 5, 2026 18:00
@ivankatliarchuk ivankatliarchuk marked this pull request as draft January 7, 2026 09:57
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2026
@ivankatliarchuk
Merge branch 'master' into chore-tools
c909bda 
* master:
  fix(api): rollback changes for omitempty (kubernetes-sigs#6086)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#6080)
  fix(aws): enable AWS API validation for routing policies without setIdentifier (kubernetes-sigs#6082)
  chore(aws): document and test behavior for ALB and NLB (kubernetes-sigs#6063)
  chore(doc): Adding EKS Pod Identity Associations section for AWS (kubernetes-sigs#6084)
  chore(source)!: remove cloudfoundry support (kubernetes-sigs#6074)
  docs(source): autogenerate docs for sources with go-doc like style (kubernetes-sigs#6075)
  docs(rfc2136): document AXFR requirement for sync policy (kubernetes-sigs#6083)
@ivankatliarchuk
chore(tools): refactor CRD generation and add validation workflow
a8ab7de 
Signed-off-by: ivan katliarchuk <[email protected]>
@ivankatliarchuk ivankatliarchuk marked this pull request as ready for review January 8, 2026 08:42
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2026
@ivankatliarchuk ivankatliarchuk changed the title chore(tools): CRD generation script change and add validation workflow chore(tools): CRD generation script moved and add validation workflow Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szuecs szuecs Awaiting requested review from szuecs

@vflaux vflaux Awaiting requested review from vflaux

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

Assignees

@vflaux vflaux

Labels

chart cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. github_actions Pull requests that update GitHub Actions code scripts Issues or PRs related to internal scripts size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ivankatliarchuk @k8s-ci-robot @coveralls @vflaux