Skip to content

Conversation

@ivankatliarchuk
Copy link
Member

@ivankatliarchuk ivankatliarchuk commented Jan 4, 2026

What does it do ?

  • Extract CRD generation logic into scripts/generate-crd.sh for better maintainability (required in makefile and github action)
  • Add CI workflow to validate CRD files are up-to-date and when go.tool.mod changes
  • Add make tools-deps target to update tool dependencies

Follow-up

  • update tools version and validate regenerated CRD (latest controller-gen may produce new changes)

Motivation

  • Different controller-gen versions produce different output
  • Ensures generated files stay in sync with tool dependencies
  • Prevents CI failures from stale generated code
  • Provides make tools-deps until Dependabot supports go.tool.mod (#12050)

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@k8s-ci-robot k8s-ci-robot requested review from szuecs and vflaux January 4, 2026 17:21
@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. scripts Issues or PRs related to internal scripts size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2026
@ivankatliarchuk ivankatliarchuk changed the title chore(tools): refactor CRD generation and add validation workflow chore(tools): CRD generation script change and add validation workflow Jan 4, 2026
@coveralls
Copy link

coveralls commented Jan 4, 2026

Pull Request Test Coverage Report for Build 21045282713

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 486 unchanged lines in 18 files lost coverage.
  • Overall coverage increased (+0.2%) to 79.089%

Files with Coverage Reduction New Missed Lines %
utils.go 1 96.0%
v1alpha1/groupversion_info.go 3 0.0%
pod.go 6 95.54%
node.go 6 90.48%
openshift_route.go 6 85.51%
ingress.go 6 88.72%
contour_httpproxy.go 7 84.14%
istio_gateway.go 8 88.07%
skipper_routegroup.go 9 38.84%
endpoint.go 17 91.01%
Totals Coverage Status
Change from base Build 20810601084: 0.2%
Covered Lines: 16033
Relevant Lines: 20272

💛 - Coveralls

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk force-pushed the chore-tools branch 3 times, most recently from 37a5a67 to 13d0bcd Compare January 4, 2026 17:40
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
ivankatliarchuk and others added 2 commits January 5, 2026 17:55
Co-authored-by: vflaux <38909103+vflaux@users.noreply.github.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk requested a review from vflaux January 5, 2026 18:00
@ivankatliarchuk ivankatliarchuk marked this pull request as draft January 7, 2026 09:57
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2026
* master:
  fix(api): rollback changes for omitempty (kubernetes-sigs#6086)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#6080)
  fix(aws): enable AWS API validation for routing policies without setIdentifier (kubernetes-sigs#6082)
  chore(aws): document and test behavior for ALB and NLB (kubernetes-sigs#6063)
  chore(doc): Adding EKS Pod Identity Associations section for AWS (kubernetes-sigs#6084)
  chore(source)!: remove cloudfoundry support (kubernetes-sigs#6074)
  docs(source): autogenerate docs for sources with go-doc like style (kubernetes-sigs#6075)
  docs(rfc2136): document AXFR requirement for sync policy (kubernetes-sigs#6083)
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk marked this pull request as ready for review January 8, 2026 08:42
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2026
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@ivankatliarchuk ivankatliarchuk changed the title chore(tools): CRD generation script change and add validation workflow chore(tools): CRD generation script moved and add validation workflow Jan 8, 2026
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
Makefile Outdated

# Required while depedabot is not supporting go.tool.mod https://github.com/dependabot/dependabot-core/issues/12050
#? tools-deps: Update go tools defined in go.tool.mod to latest versions
tools-deps:
Copy link
Contributor

@vflaux vflaux Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tools-deps:
update-tools-deps:

or

Suggested change
tools-deps:
update-tools:

To clarify what it does?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

udpated locally. Techically there is a helper message

Screenshot 2026-01-14 at 23 45 37

Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
@vflaux
Copy link
Contributor

vflaux commented Jan 15, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2026
Copy link
Collaborator

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small typo to fix

Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2026
@mloiseleur
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2026
@k8s-ci-robot k8s-ci-robot merged commit 73e0dba into kubernetes-sigs:master Jan 15, 2026
19 checks passed
ivankatliarchuk added a commit to gofogo/k8s-sigs-external-dns-fork that referenced this pull request Jan 16, 2026
* master: (25 commits)
  feat(event): standardize event messages and add resource kind lookup for events (kubernetes-sigs#6101)
  refactor(informers): unify cache sync functions using generics (kubernetes-sigs#6102)
  fix(fqdn): support kind and api version (kubernetes-sigs#6097)
  test(fqdn): cover sources without any fqdn tests (kubernetes-sigs#6094)
  chore(tools): CRD generation script moved and add validation workflow (kubernetes-sigs#6079)
  fix(metrics): add CNAME to known record types (kubernetes-sigs#6115)
  chore(cloudflare): migrate customhostname to v5 (kubernetes-sigs#5891)
  test(provider/exoscale): improved the test coverage for exoscale provider from 62.8% to 80.4%  (kubernetes-sigs#6112)
  feat(source): gateway api hostname source annotation (kubernetes-sigs#5959)
  test: cover pkg/events/fake package (kubernetes-sigs#6096)
  refactor(controller): controller no longer responsible for SingletonClientGenerator creation (kubernetes-sigs#6077)
  refactor(source): standardize FQDN template accross sources (kubernetes-sigs#6093)
  feat(coredns): rename ownerId and ownedBy to owner (kubernetes-sigs#6032)
  docs: fix typo in README (The are → There are) (kubernetes-sigs#6095)
  refactor(aws): abstract provider-specific boolean parsing (kubernetes-sigs#6078)
  refactor(api): deduplicate addKnownTypes (kubernetes-sigs#6087)
  fix(api): rollback changes for omitempty (kubernetes-sigs#6086)
  chore(deps): bump renovatebot/github-action (kubernetes-sigs#6080)
  fix(aws): enable AWS API validation for routing policies without setIdentifier (kubernetes-sigs#6082)
  chore(aws): document and test behavior for ALB and NLB (kubernetes-sigs#6063)
  ...
@ivankatliarchuk ivankatliarchuk mentioned this pull request Jan 16, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. chart cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. github_actions Pull requests that update GitHub Actions code lgtm "Looks good to me", indicates that a PR is ready to be merged. scripts Issues or PRs related to internal scripts size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants