Skip to content

Commit f76c994

Browse files
committed
make v1a2 the extension
1 parent 4207d68 commit f76c994

File tree

6 files changed

+12
-8
lines changed

6 files changed

+12
-8
lines changed

api/v1/inferencepool_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ type InferencePoolSpec struct {
7575

7676
// Extension configures an endpoint picker as an extension service.
7777
// +required
78-
ExtensionRef Extension `json:"extensionRef,omitempty,omitzero"`
78+
ExtensionRef Extension `json:"extensionRef,omitzero"`
7979
}
8080

8181
type Port struct {

apix/v1alpha2/inferencepool_conversion.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ func (src *InferencePool) ConvertTo(dst *v1.InferencePool) error {
3131
if dst == nil {
3232
return errors.New("dst cannot be nil")
3333
}
34-
v1Extension, err := convertExtensionRefToV1(&src.Spec.ExtensionRef)
34+
v1Extension, err := convertExtensionRefToV1(src.Spec.ExtensionRef)
3535
if err != nil {
3636
return err
3737
}
@@ -69,7 +69,7 @@ func (dst *InferencePool) ConvertFrom(src *v1.InferencePool) error {
6969
dst.TypeMeta = src.TypeMeta
7070
dst.ObjectMeta = src.ObjectMeta
7171
dst.Spec.TargetPortNumber = int32(src.Spec.TargetPorts[0].Number)
72-
dst.Spec.ExtensionRef = *extensionRef
72+
dst.Spec.ExtensionRef = extensionRef
7373
dst.Status = *status
7474
if src.Spec.Selector.MatchLabels != nil {
7575
dst.Spec.Selector = make(map[LabelKey]LabelValue, len(src.Spec.Selector.MatchLabels))

apix/v1alpha2/inferencepool_conversion_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func TestInferencePoolConvertTo(t *testing.T) {
6060
"app": "my-model-server",
6161
},
6262
TargetPortNumber: 8080,
63-
ExtensionRef: Extension{
63+
ExtensionRef: &Extension{
6464
Group: &group,
6565
Kind: &kind,
6666
Name: "my-epp-service",
@@ -273,7 +273,7 @@ func TestInferencePoolConvertFrom(t *testing.T) {
273273
"app": "my-model-server",
274274
},
275275
TargetPortNumber: 8080,
276-
ExtensionRef: Extension{
276+
ExtensionRef: &Extension{
277277
Group: &group,
278278
Kind: &kind,
279279
Name: "my-epp-service",

apix/v1alpha2/inferencepool_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ type InferencePoolSpec struct {
7171

7272
// Extension configures an endpoint picker as an extension service.
7373
// +required
74-
ExtensionRef Extension `json:"extensionRef,omitempty"`
74+
ExtensionRef *Extension `json:"extensionRef,omitempty"`
7575
}
7676

7777
// Extension specifies how to configure an extension that runs the endpoint picker.

apix/v1alpha2/zz_generated.deepcopy.go

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/epp/util/testing/wrappers.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ func (m *XInferencePoolWrapper) TargetPortNumber(p int32) *XInferencePoolWrapper
252252
}
253253

254254
func (m *XInferencePoolWrapper) ExtensionRef(name string) *XInferencePoolWrapper {
255-
m.Spec.ExtensionRef = v1alpha2.Extension{Name: v1alpha2.ObjectName(name)}
255+
m.Spec.ExtensionRef = &v1alpha2.Extension{Name: v1alpha2.ObjectName(name)}
256256
return m
257257
}
258258

0 commit comments

Comments
 (0)