-
Notifications
You must be signed in to change notification settings - Fork 135
feat: avoid duplicate of InferencPool golang types #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: capri-xiyue The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @capri-xiyue. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @robscott |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/ok-to-test |
/retest |
This approach makes sense to me, thanks @capri-xiyue! /lgtm |
# Conflicts: # config/crd/bases/inference.networking.x-k8s.io_inferencepools.yaml
003a8a8
to
2800ae8
Compare
New changes are detected. LGTM label has been removed. |
@danehans Can you help review this PR? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
avoid duplicate of InferencPool golang types following https://github.com/kubernetes-sigs/gateway-api/blob/093f6538409c071e906856bd1ce4072204fb3f08/apis/v1beta1/gateway_types.go#L48-L55.
It comes with the limitation that the crd-gen will just generate v1 InferencePool CRD and won't generate alpha InferencePool CRD. It is probably because we are using https://github.com/kubernetes-sigs/gateway-api/blob/093f6538409c071e906856bd1ce4072204fb3f08/apis/v1beta1/gateway_types.go#L48-L55.
for InferencePool here with v1 and alpha InferencePool actually belongs to different groups, one with
inferencepools.inference.networking.k8s.io
and the other withinferencepools.inference.networking.x-k8s.io
The PR will cause
inferencepools.inference.networking.x-k8s.io
InferencePool CRDEndpointPickerConfig
andInferencePoolSpec
, onlyInferencePool
andInferencePoolList
will be kept.inferencepools.inference.networking.x-k8s.io
InferencePool CRD no longer exists, any test includinginferencepools.inference.networking.x-k8s.io
InferencePool CRD will need to get removed.Here is the graph
type InferencePool v1.InferencePool
syntax)Rationale
We'd encourage users and controllers to exclusively focus on the v1 API going forward, thus we omit the v1alpha2 CRD from the release. However, this PR leaves controllers with the option to support both v1a2 and v1 concurrently. An approach is to represent alpha InferencePool in v1 InferencePool but override the group to
inference.networking.x-k8s.io