-
Notifications
You must be signed in to change notification settings - Fork 135
feat(conformance): Use CRD annotation to populate the ConformanceReport GatewayAPIInferenceExtensionVersion #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @zetxqx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @robscott |
/ok-to-test |
/approve This looks good to me. Will let one of the manual assignees give final stamp |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, zetxqx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @zetxqx! /lgtm |
Thanks! @kfswain /hold Looks like the manifest in the latest release(https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/tag/v0.5.1) does not have the annotation yet. This should be submitted after a new release. |
Sorry, what annotation is needed? We probably wont have a release for a bit, so trying to understand what's preventing this from merging |
@kfswain the change here reads the annotation from inferencePool's CRD to populate the ConformanceReport
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Currently, the conformance report is using hard-coded variable
BundleVersion
inversion.go
. This PR get the version from annotationBundleVersionAnnotation
of installed CRDs.Tested locally, the following is an example generated report, I installed v0.5.0 CRDs.
A follow up PR is to change
BundleVersion
fromv1.0.0-dev
tomain-dev
.