generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 136
adding fairness-id header to be used in flow control #1282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
/* | ||
Copyright 2025 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package handlers | ||
|
||
import ( | ||
"context" | ||
"testing" | ||
|
||
configPb "github.com/envoyproxy/go-control-plane/envoy/config/core/v3" | ||
extProcPb "github.com/envoyproxy/go-control-plane/envoy/service/ext_proc/v3" | ||
) | ||
|
||
func TestHandleRequestHeaders(t *testing.T) { | ||
t.Parallel() | ||
|
||
// Setup a mock server and request context | ||
server := &StreamingServer{ | ||
fairnessIDHeaderKey: "test-fairness-id", | ||
} | ||
|
||
reqCtx := &RequestContext{ | ||
Request: &Request{ | ||
Headers: make(map[string]string), | ||
}, | ||
} | ||
|
||
req := &extProcPb.ProcessingRequest_RequestHeaders{ | ||
RequestHeaders: &extProcPb.HttpHeaders{ | ||
Headers: &configPb.HeaderMap{ | ||
Headers: []*configPb.HeaderValue{ | ||
{ | ||
Key: "x-test-header", | ||
Value: "test-value", | ||
}, | ||
{ | ||
Key: "test-fairness-id", | ||
Value: "test-fairness-id-value", | ||
}, | ||
}, | ||
}, | ||
EndOfStream: false, | ||
}, | ||
} | ||
|
||
err := server.HandleRequestHeaders(context.Background(), reqCtx, req) | ||
if err != nil { | ||
t.Fatalf("expected no error, got %v", err) | ||
} | ||
|
||
if reqCtx.FairnessID != "test-fairness-id-value" { | ||
t.Errorf("expected fairness ID to be 'test-fairness-id-value', got %s", reqCtx.FairnessID) | ||
} | ||
if reqCtx.Request.Headers["test-fairness-id"] == "test-fairness-id-value" { | ||
t.Errorf("expected fairness ID header to be removed from request headers, but it was not") | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have an open issue #1267 which is about removing destination headers from cmd line args.
this looks more of the same.
the main point is that protocol specifics shouldn't be configurable. this is the protocol and whoever wants to use GIE should use the headers according to the protocol.. so IMO fairness id header shouldn't be configurable same as the other two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure. How did you want to handle the transition? My thinking was that until we do that transition, we want to keep the functionality similar.
I can remove this flag in this PR but then its special cased until we remove the others. LMKWYT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about the opposite direction.. instead of adding third flag that should be removed, we could remove in this PR the two other flags and mark #1267 as fixed.
but that's ok we can continue with current version and handle that issue separately.