Skip to content

feat: Filter out stale metrics #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

nayihz
Copy link
Contributor

@nayihz nayihz commented Aug 6, 2025

fix: #1292

/cc @liu-cong

@k8s-ci-robot k8s-ci-robot requested a review from liu-cong August 6, 2025 10:28
Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 654199f
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68934e3016b0d90008cb503d
😎 Deploy Preview https://deploy-preview-1309--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 6, 2025
@nayihz nayihz force-pushed the podlist_with_staletime branch from cdfb000 to 6348fcb Compare August 6, 2025 10:41
@nayihz
Copy link
Contributor Author

nayihz commented Aug 6, 2025

I see @nirrozenbaum will remove datastore dependency from saturation detector in #1293. I think we need to refractor some logic in getCandidatePodsForScheduling after that PR merged.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2025
@nayihz nayihz closed this Aug 6, 2025
@nayihz nayihz force-pushed the podlist_with_staletime branch from 6348fcb to 654199f Compare August 6, 2025 12:44
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nayihz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying metricsStalenessThreshold in datastore.PodList predicate function
2 participants