-
Notifications
You must be signed in to change notification settings - Fork 135
Affiliate ready state with leader election with a flag ha-enable-leader-election #1337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Welcome @yangligt2! |
Hi @yangligt2. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm Comitted a small typo edit, but otherwise looks great! Thank you for this! |
/hold Ahh shoot. Can we add the flag to the helm chart? This file here: gateway-api-inference-extension/config/charts/inferencepool/templates/epp-deployment.yaml Line 52 in d27a716
|
config/charts/inferencepool/templates/leader-election-rbac.yaml
Outdated
Show resolved
Hide resolved
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, yangligt2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
and to the chart README please. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
forgot to unhold, sorry about that! since we need to rebase anyway, updating the readme would be great. |
@yangligt2: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Closes #1264
Summary
This PR introduces a leader election mechanism using Kubernetes Leases to allow the service to run in a high-availability (HA) mode. When enabled, only the leader instance will run the main reconciliation loop, preventing multiple replicas from acting on the same resources simultaneously.
Implementation Details
How to Test
Added 2 new test cases in test-e2e to:
To run the test, use command
E2E_LEADER_ELECTION_ENABLED=true make test-e2e