-
Notifications
You must be signed in to change notification settings - Fork 135
[bug] Fix datalayer Collector test flake #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Etai Lev Ran <[email protected]>
Signed-off-by: Etai Lev Ran <[email protected]>
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elevran The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Etai Lev Ran <[email protected]>
/hold |
Signed-off-by: Etai Lev Ran <[email protected]>
Signed-off-by: Etai Lev Ran <[email protected]>
/unhold |
Signed-off-by: Etai Lev Ran <[email protected]>
This fixes a test race condition when the start of the collector goroutine is delayed (e.g., on a loaded system).
In the original code, ticks are sent immediately upon return from
Start
. Unfortunately, there is a race condition due to timing: the collector's goroutine might not have reached the select statement when the ticks are sent.The test timing is unpredictable:
Stop
is called, the test passes.The fix is in both the test and collector code:
Do()
)require.Eventually
(with a much shorter timeout compared to before)/cc @ahg-g