Skip to content

feat: TargetPortNumber int32 to become TargetPorts []Port #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: TargetPortNumber int32 to become TargetPorts []Port #1354

wants to merge 11 commits into from
+163 −51

Conversation

capri-xiyue
Copy link
Contributor

part of #1336

  1. change TargetPortNumber int32 to become TargetPorts []Port, where Port includes only a Number field to start in InferencePool v1.
  2. to avoid break change for now, currently TargetPosts only allows exactly one item

@netlify Netlify
Copy link

netlify bot commented Aug 11, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 4dc98d9
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/689a861d6518a20007e49324
😎 Deploy Preview https://deploy-preview-1354--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @capri-xiyue. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 11, 2025
@liu-cong
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2025
@capri-xiyue
Copy link
Contributor Author

/assign @ahg-g

@capri-xiyue
Copy link
Contributor Author

This is ready for early review. I will add additional conversion logic once #1330 gets merged.

/hold until #1330 gets merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2025
@capri-xiyue
Copy link
Contributor Author

/assign @danehans @nirrozenbaum for InferencePool spec change.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: capri-xiyue
Once this PR has been reviewed and has the lgtm label, please ask for approval from ahg-g. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

robscott
robscott reviewed Aug 11, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @capri-xiyue! This LGTM, curious what others like @danehans and @nirrozenbaum think.

capri-xiyue
capri-xiyue commented Aug 11, 2025
View reviewed changes
pkg/epp/controller/inferencepool_reconciler_test.go
@@ -282,7 +283,8 @@ func TestXInferencePoolReconciler(t *testing.T) {
if err := fakeClient.Get(ctx, req.NamespacedName, newPool1); err != nil {
t.Errorf("Unexpected pool get error: %v", err)
}
newPool1.Spec.TargetPortNumber = 9090
// TODO: change it later to 9090
newPool1.Spec.TargetPortNumber = 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, will change it back once #1330 gets merged.

@robscott robscott mentioned this pull request Aug 11, 2025
Open
robscott
robscott reviewed Aug 11, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @capri-xiyue!

@capri-xiyue capri-xiyue requested a review from robscott August 12, 2025 00:21
aslakknutsen
aslakknutsen reviewed Aug 12, 2025
View reviewed changes
site-src/guides/inferencepool-rollout.md
@@ -208,7 +208,8 @@ kind: InferencePool
metadata:
name: vllm-llama3-8b-instruct-new
spec:
targetPortNumber: 8000
targetPorts:
- portNumber: 8000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- portNumber: 8000
- number: 8000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslakknutsen aslakknutsen aslakknutsen left review comments

@kfswain kfswain Awaiting requested review from kfswain

@robscott robscott Awaiting requested review from robscott

Assignees

@ahg-g ahg-g

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@capri-xiyue @k8s-ci-robot @liu-cong @aslakknutsen @robscott @ahg-g