Skip to content

Conversation

zhengkezhou1
Copy link
Contributor

fix: #1271

version the epp changes

Signed-off-by: zhengkezhou1 <[email protected]>
Copy link

netlify bot commented Aug 12, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit b86d370
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68de6c100e1d1c0008c99dd6
😎 Deploy Preview https://deploy-preview-1360--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and robscott August 12, 2025 11:33
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 12, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zhengkezhou1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Aug 15, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2025
Signed-off-by: zhengkezhou1 <[email protected]>
@zhengkezhou1 zhengkezhou1 force-pushed the doc/vesrion-epp-protocol branch from dd85d38 to a76e5ec Compare August 18, 2025 18:54

| Version | Date | Changes |
|----------|------------|--------------------------------------------------|
| dev-main | 2025-07-29 | Added status metadata field for picked endpoints |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhengkezhou1 this is a good start. Can you create a separate issue to add this table to https://gateway-api-inference-extension.sigs.k8s.io/guides/implementers/#callout-extension and tooling that automates the maintenance of the table? We may need to move the EPP proto spec outside of the proposals directory and treat it similarly to API types, e.g. something similar to api-ref-docs to maintain the spec.

Copy link
Contributor

@danehans danehans Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change dev-main to v1.0.0.

@kfswain
Copy link
Collaborator

kfswain commented Sep 16, 2025

Heya @zhengkezhou1 I think if we include the other major version releases we can get this merged in, thanks!!

@danehans
Copy link
Contributor

danehans commented Oct 1, 2025

Signed-off-by: zhengkezhou1 <[email protected]>
@zhengkezhou1
Copy link
Contributor Author

sorry for low response, i create a issue to trace.

@kfswain
Copy link
Collaborator

kfswain commented Oct 10, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, zhengkezhou1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 175b65a into kubernetes-sigs:main Oct 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPP: Version the Endpoint Picker Protocol
5 participants