-
Notifications
You must be signed in to change notification settings - Fork 182
feat :Add GetActivePods to handle/datastore and remove deleted pod from prefix-cache scorer #1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @kfirtoledo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @nirrozenbaum |
/hold |
@elevran is this aligned with the new datalayer APIs? |
I don't see a conflict - the datastore API is minimally affected. |
/lgtm |
/ok-to-test |
/lgtm |
Hey @kfirtoledo I see you have a hold on this PR, is this something we are still working on? |
Hi, @kfswain I wasn't able to check it in e2e test, I was waiting the quickstart will work after all the v.1.0 changes |
@kfirtoledo now that v1.0.0 (and subsequently v1.0.1) was cut, can you follow-up on #1376 (comment), resolve the merge conflict, etc? |
Heya @kfirtoledo just an FYI, we plan on cutting an RC for the next release sometime next week, if we wanted to include this it should try to merge before then. |
Signed-off-by: Kfir Toledo <[email protected]>
/unhold |
/lgtm I am OK with merging this without a complete benchmark, as it introduces an async cleanup and doesn't change the main prefix score code path. Our automatic regression test should be able to capture it should any regression is introduced. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfirtoledo, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Kfir Toledo <[email protected]>
This PR introduces two main enhancements:
These changes allow plugins to query active pods directly from the handle and support cache cleanup for inactive pods in the prefix-cache scorer (Fix #1289)