Skip to content

Conversation

nirrozenbaum
Copy link
Contributor

Fix #1367

env vars are not needed for cmd-line args. this PR removes this duplication.
another minor change is defining cmd-arg in single line instead of 3 lines, which makes it hard for a reader to find the cmd-line args. no change in cmd-line args except for removing "new lines".

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2025
Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit f971294
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68a3105ef860e1000869721b
😎 Deploy Preview https://deploy-preview-1397--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and robscott August 18, 2025 11:37
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2025
@kfswain
Copy link
Collaborator

kfswain commented Aug 21, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit d1fe78f into kubernetes-sigs:main Aug 21, 2025
10 checks passed
@nirrozenbaum nirrozenbaum deleted the rm-env-vars branch August 21, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EndpointPicker: Duplicate flags in runner.go in EPP

3 participants