Skip to content

Conversation

yangligt2
Copy link
Contributor

What type of PR is this?
/kind bug
/kind failing-test

What this PR does / why we need it:
When High Availability (HA) is enabled on GKE, the GCP backend service health check uses an empty string service name, which incorrectly causes all pods to be reported as healthy, regardless of their actual readiness state.

This PR fixes this behavior by mapping the empty string health check to use the pod's readiness probe status. This ensures that the GCP backend service only considers ready pods as healthy and prevents traffic from being routed to pods that are not yet able to serve requests. This change does not affect the standard Kubernetes liveness and readiness probes.

Which issue(s) this PR fixes:
Fixes failing-test on GKE for #1337

Does this PR introduce a user-facing change?:
No

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Aug 18, 2025
Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit a58fef4
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68a3c5495de5df000835e7c0
😎 Deploy Preview https://deploy-preview-1402--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @yangligt2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 18, 2025
checkName = "readiness"
isPassing = isLive && s.isLeader.Load()
case LivenessCheckService, "": // Default to liveness check if service is empty
case "": // Handle overall server health for load balancers that use an empty service name.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very minor, non-blocking nit: move the empty string case to the bottom of the list

@kfswain
Copy link
Collaborator

kfswain commented Aug 18, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, yangligt2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@yangligt2 yangligt2 force-pushed the fix/gke-backends-healthcheck branch from d08d352 to a58fef4 Compare August 19, 2025 00:28
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Aug 19, 2025
@kfswain
Copy link
Collaborator

kfswain commented Aug 19, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2025
@kfswain
Copy link
Collaborator

kfswain commented Aug 19, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2f67dc9 into kubernetes-sigs:main Aug 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants