-
Notifications
You must be signed in to change notification settings - Fork 182
Fix: Handle empty string healthcheck as readiness healthcheck #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Handle empty string healthcheck as readiness healthcheck #1402
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @yangligt2. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
checkName = "readiness" | ||
isPassing = isLive && s.isLeader.Load() | ||
case LivenessCheckService, "": // Default to liveness check if service is empty | ||
case "": // Handle overall server health for load balancers that use an empty service name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very very minor, non-blocking nit: move the empty string case to the bottom of the list
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, yangligt2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Cong Liu <[email protected]>
d08d352
to
a58fef4
Compare
/ok-to-test |
/lgtm |
What type of PR is this?
/kind bug
/kind failing-test
What this PR does / why we need it:
When High Availability (HA) is enabled on GKE, the GCP backend service health check uses an empty string service name, which incorrectly causes all pods to be reported as healthy, regardless of their actual readiness state.
This PR fixes this behavior by mapping the empty string health check to use the pod's readiness probe status. This ensures that the GCP backend service only considers ready pods as healthy and prevents traffic from being routed to pods that are not yet able to serve requests. This change does not affect the standard Kubernetes liveness and readiness probes.
Which issue(s) this PR fixes:
Fixes failing-test on GKE for #1337
Does this PR introduce a user-facing change?:
No