Skip to content

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Aug 20, 2025

What type of PR is this?

/kind bug

Optionally add one or more of the following kinds if applicable:

/kind failing-test
/area conformance-test

What this PR does / why we need it:

Updates the InferencePoolResolvedRefsCondition conformance test to comply with the API spec by checking for the default parent condition when a controller no longer manages the InferencePool and no other parents exist:

type InferencePoolStatus struct {
	// Parents is a list of parent resources (usually Gateways) that are
	// associated with the InferencePool, and the status of the InferencePool with respect to
	// each parent.
	//
	// A maximum of 32 Gateways will be represented in this list. When the list contains
	// `kind: Status, name: default`, it indicates that the InferencePool is not
	// associated with any Gateway and a controller must perform the following:
	//
	//  - Remove the parent when setting the "Accepted" condition.
	//  - Add the parent when the controller will no longer manage the InferencePool
	//    and no other parents exist.
	//
	// +kubebuilder:validation:MaxItems=32
	// +optional
	// +listType=atomic
	Parents []PoolStatus `json:"parent,omitempty"`
}

Which issue(s) this PR fixes:

Fixes #1407

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Aug 20, 2025
@k8s-ci-robot
Copy link
Contributor

@danehans: The label(s) area/conformance-test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind bug

Optionally add one or more of the following kinds if applicable:

/kind failing-test
/area conformance-test

What this PR does / why we need it:

Updates the InferencePoolResolvedRefsCondition conformance test to comply with the API spec:

type InferencePoolStatus struct {
  // Parents is a list of parent resources (usually Gateways) that are
  // associated with the InferencePool, and the status of the InferencePool with respect to
  // each parent.
  //
  // A maximum of 32 Gateways will be represented in this list. When the list contains
  // `kind: Status, name: default`, it indicates that the InferencePool is not
  // associated with any Gateway and a controller must perform the following:
  //
  //  - Remove the parent when setting the "Accepted" condition.
  //  - Add the parent when the controller will no longer manage the InferencePool
  //    and no other parents exist.
  //
  // +kubebuilder:validation:MaxItems=32
  // +optional
  // +listType=atomic
  Parents []PoolStatus `json:"parent,omitempty"`
}

Which issue(s) this PR fixes:

Fixes #1407

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 20, 2025
@danehans
Copy link
Contributor Author

Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit fb8f057
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68a5f201e09596000825ccca
😎 Deploy Preview https://deploy-preview-1415--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danehans danehans added this to the v1.0 (InferencePool GA) milestone Aug 20, 2025
@danehans
Copy link
Contributor Author

cc: @zetxqx

@danehans
Copy link
Contributor Author

Closing since https://kubernetes.slack.com/archives/C08E3RZMT2P/p1755725799708619 decided to remove the default status condition for the v1.0 release.

@danehans danehans closed this Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InferencePoolResolvedRefsCondition Should Assert Default Parent Condition

2 participants