-
Notifications
You must be signed in to change notification settings - Fork 182
Conformance: Updates InferencePoolResolvedRefsCondition Test #1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Daneyon Hansen <[email protected]>
@danehans: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cc: @zetxqx |
Closing since https://kubernetes.slack.com/archives/C08E3RZMT2P/p1755725799708619 decided to remove the default status condition for the v1.0 release. |
What type of PR is this?
/kind bug
Optionally add one or more of the following kinds if applicable:
/kind failing-test
/area conformance-test
What this PR does / why we need it:
Updates the InferencePoolResolvedRefsCondition conformance test to comply with the API spec by checking for the default parent condition when a controller no longer manages the InferencePool and no other parents exist:
Which issue(s) this PR fixes:
Fixes #1407
Does this PR introduce a user-facing change?: