-
Notifications
You must be signed in to change notification settings - Fork 182
Add initial troubleshooting guide #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial troubleshooting guide #1430
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @nicolexin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @kfswain |
Looks good! Just some minor tweaks, thanks so much! /ok-to-test |
Co-authored-by: Kellen Swain <[email protected]>
Co-authored-by: Kellen Swain <[email protected]>
Co-authored-by: Kellen Swain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks really great!
site-src/guides/troubleshooting.md
Outdated
|
||
For unexpected routing behaviors: | ||
|
||
* Verify the expected metrics are being emitted from the model server. Some model servers aren't fully compatible with the default expected metrics, vLLM is generally the most up-to-date in this regard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls add the supported model server link https://gateway-api-inference-extension.sigs.k8s.io/implementations/model-servers/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
* `DefaultMetricsStalenessThreshold`: This defines the maximum age of metrics data before it's considered outdated. The default is 200 milliseconds. The saturation detector needs up-to-date metrics to make accurate decisions about system load. If the metrics are older than this threshold, the detector won't use them. This value is tied to how often metrics are refreshed, and setting it slightly higher ensures that there's always fresh data available. To override this, set the `SD_METRICS_STALENESS_THRESHOLD` environment variable. | ||
|
||
## 500 Internal Server Error | ||
### `fault filter abort` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these errors specific to GKE gateway or are they common Gateway API error codes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. The 500 fault filter abort error is common when the backend does not exist. The 503 is also common when there is no healthy endpoint to route to. The only thing that can diverge is when port is misconfigured - I believe GKE and Istio gives 503 Service Available but KGateway gives 502 Bad Gateway. I have updated the doc to add 502 error code.
Co-authored-by: Cong Liu <[email protected]>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, nicolexin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
apiVersion: gateway.networking.k8s.io/v1beta1 | ||
kind: ReferenceGrant | ||
metadata: | ||
name: ref-grant | ||
namespace: ns2 | ||
spec: | ||
from: | ||
- group: gateway.networking.k8s.io | ||
kind: HTTPRoute | ||
namespace: ns1 | ||
to: | ||
- group: inference.networking.k8s.io | ||
kind: InferencePool | ||
name: my-inference-pool | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, was this ever tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about other implementations but recently we found a bug where ReferenceGrant does not work properly with InferencePool, that was fixed in GKE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we better have one. Just created a github issue: #1487 to track it.
But note: the refGrant is never mentioned in the inference extension API spec.
### `failed to list <InferencePool or InferenceObjective or Pod>: … is forbidden` | ||
The EPP needs to watch the InferencePool, InferenceObjectives and Pods that belong to them. This constant watching and reconciliation allows the EPP to maintain an up-to-date view of the environment, enabling it to make dynamic decisions. This particular error indicates that the service account used by the EPP doesn't have the necessary permissions to list the resources it’s watching. | ||
|
||
**Solution**: Create or update the RBAC configuration to grant the [required permissions](https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/137a0b4660b96487caac626ed135b3600be876ed/config/manifests/inferencepool-resources.yaml#L129) to the EPP service account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should avoid pointing to inferencepool-resources.yaml and only use the helm charts, we need to deprecate this manifest, I created to #1480 to track deprecating it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out! I will create a follow up PR to fix this.
* Add initial troubleshooting guide * Update mkdocs.yml to add troubleshooting guide * Rename toubleshooting.md to troubleshooting.md * Fix bullet points * Fix bullet points * Make solutions bold and clear * Update mkdocs.yml Co-authored-by: Kellen Swain <[email protected]> * Update site-src/guides/troubleshooting.md Co-authored-by: Kellen Swain <[email protected]> * Update site-src/guides/troubleshooting.md Co-authored-by: Kellen Swain <[email protected]> * Update site-src/guides/troubleshooting.md Co-authored-by: Cong Liu <[email protected]> * Update troubleshooting.md --------- Co-authored-by: Kellen Swain <[email protected]> Co-authored-by: Cong Liu <[email protected]>
Fixes #689
/kind documentation
What this PR does / why we need it:
Adding initial Troubleshooting guide for common issues