Skip to content

Conversation

@BenjaminBraunDev
Copy link
Contributor

@BenjaminBraunDev BenjaminBraunDev commented Aug 23, 2025

Adds a new directory for the latency prediction and training sidecars for upcoming experimental latency prediction and SLO based routing scheduling profiles. Full details in issue below.

This does not change nor add any functionality as is, only introduces the sidecar module directory to be used to build the training and prediction images. These will later be deployed as containers alongside the EPP image.

Fixes #1323

Does this PR introduce a user-facing change?:

NONE

@netlify
Copy link

netlify bot commented Aug 23, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit a0c20d6
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68af936490790b00083dc56a
😎 Deploy Preview https://deploy-preview-1443--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 23, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and liu-cong August 23, 2025 00:20
@k8s-ci-robot
Copy link
Contributor

Hi @BenjaminBraunDev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 23, 2025
@BenjaminBraunDev BenjaminBraunDev force-pushed the latency-prediction-sidecars branch from e079725 to a0c20d6 Compare August 27, 2025 23:23
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BenjaminBraunDev
Once this PR has been reviewed and has the lgtm label, please assign kfswain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenjaminBraunDev
Copy link
Contributor Author

@ahg-g @liu-cong @kfswain
Anything preventing this from being merged? if doesn't have any functional changes, just prepares later PRs for SLO routing.

@nirrozenbaum
Copy link
Contributor

@ahg-g @liu-cong @kfswain Anything preventing this from being merged? if doesn't have any functional changes, just prepares later PRs for SLO routing.

@BenjaminBraunDev I don't think the PR has been reviewed yet, since most of maintainers/reviewers are currently focused in v1 release and bringing this version to a good state.
current PR is more than 4K LoC, and even though it doesn't add functional changes to EPP, it does add a lot of code that should be reviewed.
unfortunately due to time constraints, I think none of the maintainers can afford to spend the time reviewing 4k+ LoC at this point for PR that is not planned for v1.
having said that, we surely want to review and merge it as soon as possible, once we remove the high priority tasks from our plate.

@ahg-g
Copy link
Contributor

ahg-g commented Sep 16, 2025

Do we still need this PR now that you have it merged in a special branch?

@BenjaminBraunDev
Copy link
Contributor Author

Do we still need this PR now that you have it merged in a special branch?

No we don't need it. We can cut this PR as obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] SLO-Aware Routing with Latency Prediction

5 participants