Skip to content

Conversation

@zetxqx
Copy link
Contributor

@zetxqx zetxqx commented Aug 25, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
While doing v1alpha2 and v1 infPool conversion, if the condition slice is empty we are always adding an empty placeholder slice. However, this is not consistent with the "omitempty"

	// +optional
	// +listType=map
	// +listMapKey=type
	// +kubebuilder:validation:MaxItems=8
	Conditions []metav1.Condition `json:"conditions,omitempty"`

Which issue(s) this PR fixes:

NONE

Does this PR introduce a user-facing change?:
NONE


@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 25, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and liu-cong August 25, 2025 15:54
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2025
@netlify
Copy link

netlify bot commented Aug 25, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit d5b9ee3
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68acc85df1608700082ec993
😎 Deploy Preview https://deploy-preview-1447--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@capri-xiyue
Copy link
Contributor

capri-xiyue commented Aug 25, 2025

I think the conversion should map

  1. nil to nil
  2. [] to []

cc @zetxqx

also cc @danehans @robscott @kfswain Seems like we are going to cut the release

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2025
@zetxqx
Copy link
Contributor Author

zetxqx commented Aug 25, 2025

I think the conversion should map

  1. nil to nil
  2. [] to []

cc @zetxqx

also cc @danehans @robscott @kfswain Seems like we are going to cut the release

done

@zetxqx
Copy link
Contributor Author

zetxqx commented Aug 25, 2025

/assign @danehans

@danehans
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, zetxqx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7663773 into kubernetes-sigs:main Aug 25, 2025
10 checks passed
@zetxqx zetxqx deleted the apifix branch September 29, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants