Skip to content

Conversation

@rahulgurnani
Copy link
Contributor

@rahulgurnani rahulgurnani commented Aug 27, 2025

What type of PR is this?
/kind gep

What this PR does / why we need it:
While setting provider name as gke for the helm chart, make the provider name not case sensitive.

Which issue(s) this PR fixes:

Addresses #1482

Does this PR introduce a user-facing change?:

Yes.

@k8s-ci-robot
Copy link
Contributor

@rahulgurnani: The label(s) kind/gep cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind gep

What this PR does / why we need it:
While setting provider name as "gke" for the helm chart, make the provider name not case sensitive.

Which issue(s) this PR fixes:

Fixes #1482

Does this PR introduce a user-facing change?:

Yes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify
Copy link

netlify bot commented Aug 27, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 716e864
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68af758b6ca48f0008cf1cae
😎 Deploy Preview https://deploy-preview-1486--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and danehans August 27, 2025 17:30
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rahulgurnani. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 27, 2025
@rahulgurnani rahulgurnani marked this pull request as draft August 27, 2025 17:31
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2025
@rahulgurnani rahulgurnani marked this pull request as ready for review August 27, 2025 17:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2025
@rahulgurnani rahulgurnani changed the title Updat provider name to be not case sensitive Update provider name to be not case sensitive Aug 27, 2025
@rahulgurnani rahulgurnani changed the title Update provider name to be not case sensitive Update provider name in helm chart for GKE to be not case sensitive Aug 27, 2025
@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2025
@nirrozenbaum
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum, rahulgurnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit bc87672 into kubernetes-sigs:main Aug 28, 2025
10 checks passed
@kfswain kfswain mentioned this pull request Aug 28, 2025
kfswain pushed a commit that referenced this pull request Aug 28, 2025
…1486)

* Updat provider name to be not case sensitive

* Update config/charts/inferencepool/templates/gke.yaml

Co-authored-by: Nir Rozenbaum <[email protected]>

---------

Co-authored-by: Nir Rozenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants