-
Couldn't load subscription status.
- Fork 185
Update provider name in helm chart for GKE to be not case sensitive #1486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rahulgurnani: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @rahulgurnani. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Co-authored-by: Nir Rozenbaum <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum, rahulgurnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…1486) * Updat provider name to be not case sensitive * Update config/charts/inferencepool/templates/gke.yaml Co-authored-by: Nir Rozenbaum <[email protected]> --------- Co-authored-by: Nir Rozenbaum <[email protected]>
What type of PR is this?
/kind gep
What this PR does / why we need it:
While setting provider name as gke for the helm chart, make the provider name not case sensitive.
Which issue(s) this PR fixes:
Addresses #1482
Does this PR introduce a user-facing change?: