Skip to content

feat(helm): add affinity and tolerations to epp-deployment #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2025
Merged

feat(helm): add affinity and tolerations to epp-deployment #1504

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c7442c
feat(helm): add affinity and tolerations to epp-deployment
hhk7734 Aug 29, 2025
7b52733
docs(helm): add affinity and tolerations to inferencepool chart README
hhk7734 Aug 30, 2025
d6f2bcc
chore(helm): use `if` instead of `with`
hhk7734 Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions config/charts/inferencepool/templates/epp-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,11 @@ spec:
- name: plugins-config-volume
configMap:
name: {{ include "gateway-api-inference-extension.name" . }}
{{- with .Values.inferenceExtension.affinity }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we replace the “with” with “if”?

Suggested change
{{- with .Values.inferenceExtension.affinity }}
{{- if .Values.inferenceExtension.affinity }}

Copy link
Contributor Author

@hhk7734 hhk7734 Aug 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Values.inferenceExtension.extraContainerPorts and .Values.inferenceExtension.env also use with. Since this follows the same pattern, I’d suggest keeping it as is. Do you agree?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I’d change those to using “if” as well. I less like the use of “placeholders” and empty vars in the values file.
I personally prefer to have these options well documented and removed when not used.
I’ll defer to @kfswain to get his opinion.

Copy link
Contributor Author

@hhk7734 hhk7734 Sep 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d6f2bcc
I modified it to use if instead of with.

affinity:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.inferenceExtension.tolerations }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Suggested change
{{- with .Values.inferenceExtension.tolerations }}
{{- if .Values.inferenceExtension.tolerations }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here as well.

tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
4 changes: 4 additions & 0 deletions config/charts/inferencepool/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ inferenceExtension:
- name: v
value: 1

affinity: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then we can remove empty values of affinity and tolerations from values.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should remain to show that affinity and tolerations can be set.


tolerations: []

inferencePool:
targetPorts:
- number: 8000
Expand Down