Skip to content

Update priority in EPP flow control from uint to int #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2025
Merged

Update priority in EPP flow control from uint to int #1518

merged 3 commits into from
Sep 10, 2025

Conversation

rahulgurnani
Copy link
Contributor

@rahulgurnani rahulgurnani commented Sep 3, 2025 •
edited
Loading

What type of PR is this?

/kind bug or refactor
What this PR does / why we need it:

This PR updates the type of priority from uint to int in flow control to ensure its in sync with what we have in API spec.
Presently, the priority in API spec is an int whereas in the EPP flow control is an unsigned int

Which issue(s) this PR fixes:

Fixes #1473

Does this PR introduce a user-facing change?:

cc @LukeAVanDrie

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 3, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rahulgurnani. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 3, 2025
@netlify Netlify
Copy link

netlify bot commented Sep 3, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit cb78e8d
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68c1c1cada455e00084b32c0
😎 Deploy Preview https://deploy-preview-1518--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 3, 2025
@rahulgurnani rahulgurnani marked this pull request as ready for review September 3, 2025 00:55
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2025
@rahulgurnani rahulgurnani marked this pull request as draft September 3, 2025 00:56
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2025
@rahulgurnani rahulgurnani marked this pull request as ready for review September 3, 2025 21:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2025
LukeAVanDrie
LukeAVanDrie reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@LukeAVanDrie LukeAVanDrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! Just a few comments on reversing the sorting order and updating docs accordingly.

pkg/epp/flowcontrol/contracts/registry.go Outdated
PriorityBandAccessor(priority uint) (framework.PriorityBandAccessor, error)
PriorityBandAccessor(priority int) (framework.PriorityBandAccessor, error)

// AllOrderedPriorityLevels returns all configured priority levels that this shard is aware of, sorted in ascending
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted in ascending numerical order. This order corresponds to highest priority (lowest numeric value) to lowest priority (highest numeric value

We should either remove this or update it to reflect the new sorting order (highest priority is highest numeric value).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the comment, thanks!

@ahg-g
Copy link
Contributor

ahg-g commented Sep 9, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2025
ahg-g
ahg-g reviewed Sep 10, 2025
View reviewed changes
ahg-g
ahg-g reviewed Sep 10, 2025
View reviewed changes
@rahulgurnani rahulgurnani requested a review from ahg-g September 10, 2025 18:28
@ahg-g
Copy link
Contributor

ahg-g commented Sep 10, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, rahulgurnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1457f63 into kubernetes-sigs:main Sep 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danehans danehans Awaiting requested review from danehans

@liu-cong liu-cong Awaiting requested review from liu-cong

@kfswain kfswain Awaiting requested review from kfswain

@robscott robscott Awaiting requested review from robscott

@LukeAVanDrie LukeAVanDrie Awaiting requested review from LukeAVanDrie

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@ahg-g ahg-g

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update priority in flow control to make it in sync with priority in API spec

4 participants

@rahulgurnani @k8s-ci-robot @ahg-g @LukeAVanDrie