Skip to content

Added envoy proxy ai-gateway #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

Added envoy proxy ai-gateway #1554

merged 1 commit into from
Sep 10, 2025

Conversation

@learner0810
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added envoy proxy ai-gateway

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 9, 2025
@netlify
Copy link

netlify bot commented Sep 9, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 629eff0
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68c1307e4c696c000812c94f
😎 Deploy Preview https://deploy-preview-1554--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @learner0810. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 9, 2025
@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2025
nirrozenbaum
nirrozenbaum reviewed Sep 9, 2025
View reviewed changes
config/manifests/gateway/envoyaigateway/gateway.yaml Outdated
metadata:
name: inference-gateway
spec:
gatewayClassName: inference-pool-with-httproute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we name it with a more descriptive name?
e.g.,

Suggested change
gatewayClassName: inference-pool-with-httproute
gatewayClassName: envoy-ai-gateway

this is aligned with the other gateways used names, and is more descriptive, e.g., if one checks the Gateway resource, it's easy to understand what gateway is being used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it's fixed

nirrozenbaum
nirrozenbaum reviewed Sep 9, 2025
View reviewed changes
config/manifests/gateway/envoyaigateway/gateway.yaml Outdated
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
name: inference-pool-with-httproute
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Suggested change
name: inference-pool-with-httproute
name: envoy-ai-gateway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it's fixed

@learner0810 learner0810 force-pushed the add-envoyproxy-ai-gateway branch 2 times, most recently from c63399b to f137275 Compare September 10, 2025 02:34
nirrozenbaum
nirrozenbaum reviewed Sep 10, 2025
View reviewed changes
config/manifests/gateway/envoyaigateway/gateway.yaml Outdated
metadata:
name: inference-gateway
spec:
gatewayClassName: envoy-ai-gateway
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nitpick:

Suggested change
gatewayClassName: envoy-ai-gateway
gatewayClassName: envoy-ai-gateway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it's fixed

nirrozenbaum
nirrozenbaum reviewed Sep 10, 2025
View reviewed changes
config/manifests/gateway/envoyaigateway/gateway.yaml Outdated
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
name: envoy-ai-gateway
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same:

Suggested change
name: envoy-ai-gateway
name: envoy-ai-gateway

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it's fixed

@nirrozenbaum
Copy link
Contributor

/retest

@nirrozenbaum
Copy link
Contributor

@learner0810 Thanks for the PR.
this lgtm. I left two nits.
we have a flaky test in CI not related to your PR.

/approve

will lgtm after tests passes.
up to you if you want to handle the minor nits (remove extra spaces in two places)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: learner0810, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@learner0810 learner0810 force-pushed the add-envoyproxy-ai-gateway branch from f137275 to 629eff0 Compare September 10, 2025 08:02
@nirrozenbaum
Copy link
Contributor

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 83062c2 into kubernetes-sigs:main Sep 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirrozenbaum nirrozenbaum nirrozenbaum left review comments

@elevran elevran Awaiting requested review from elevran

Assignees

@nirrozenbaum nirrozenbaum

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@learner0810 @k8s-ci-robot @nirrozenbaum