-
Notifications
You must be signed in to change notification settings - Fork 184
Update getting started guide with 1.0 release #1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @rahulgurnani. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test Looks great, thanks @rahulgurnani just giving the tests a chance to pass |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, rahulgurnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| --set inferencePool.modelServers.matchLabels.app=vllm-llama3-8b-instruct \ | ||
| --set provider.name=$GATEWAY_PROVIDER \ | ||
| --version v0.5.1 \ | ||
| --version v1.0.0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm.
can we add this update to the release script (only for final release, not for RCs), so we don't need to manually update it after every release?
we have an issue opened for that #1494
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Bumping up docs to 1.0 release
Which issue(s) this PR fixes:
Fixes #1464
Does this PR introduce a user-facing change?: