Skip to content

Conversation

Gregory-Pereira
Copy link
Contributor

@Gregory-Pereira Gregory-Pereira commented Sep 10, 2025

cc @ahg-g one bugfix
Can confirm this works. The issue was that it was not templating properly, and was not using the correct variable

Signed-off-by: greg pereira <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gregory-Pereira
Once this PR has been reviewed and has the lgtm label, please assign kfswain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Gregory-Pereira. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2025
@kfswain
Copy link
Collaborator

kfswain commented Sep 10, 2025

Can we cut this fix, and the other PR to main pls?

@Gregory-Pereira Gregory-Pereira changed the title bugfix with testing bugfix for uniquely named crbac (#1545) Sep 10, 2025
@Gregory-Pereira Gregory-Pereira changed the base branch from release-1.0 to main September 10, 2025 16:00
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2025
@Gregory-Pereira Gregory-Pereira changed the base branch from main to release-1.0 September 10, 2025 16:02
@Gregory-Pereira Gregory-Pereira marked this pull request as draft September 10, 2025 16:02
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 10, 2025
@Gregory-Pereira
Copy link
Contributor Author

Closing in favor of #1564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants